Merge branch 'feature/pbs-25-07' of https://github.com/CenterForOpenScience/osf.io into impact-notifications

* 'feature/pbs-25-07' of https://github.com/CenterForOpenScience/osf.io:
  [ENG-7289] Fix Search Index Discrepancy in Collection Facets (#11085)

Author: Johnetordoff

api_tests/collections/test_views.py

@@ -21,6 +21,7 @@
 from osf.utils.permissions import ADMIN, WRITE, READ
 from website.project.signals import contributor_removed
 from api_tests.utils import disconnected_from_listeners
+from api_tests.share._utils import mock_update_share
 from website.views import find_bookmark_collection
 
 
@@ -4340,6 +4341,18 @@ def test_with_permissions(self, app, collection_with_three_collection_submission
         assert len(res.json['data']) == 0
         assert res.status_code == 200
 
+    def test_update_share_called(self, app, collection_with_zero_collection_submission, user_one, project_four, url, payload, subject_one):
+        collection_with_zero_collection_submission.is_public = True
+        collection_with_zero_collection_submission.save()
+
+        with mock_update_share() as _shmock:
+            res = app.post_json_api(
+                url.format(collection_with_zero_collection_submission._id),
+                payload(guid=project_four._id, subjects=[[subject_one._id]]),
+                auth=user_one.auth)
+            assert res.status_code == 201
+            _shmock.assert_called()
+
     def test_filters(self, app, collection_with_one_collection_submission, collection_with_three_collection_submission, project_two, project_four, user_one, subject_one, url, payload):
         res = app.get(f'{url.format(collection_with_three_collection_submission._id)}?filter[id]={project_two._id}', auth=user_one.auth)
         assert res.status_code == 200

osf/management/commands/sync_collection_provider_indices.py

@@ -26,7 +26,7 @@ def sync_collection_provider_indices(cp_ids=None, only_remove=False):
                     submission.remove_from_index()
                     remove_ct += 1
                 elif not only_remove:
-                    submission.update_index()
+                    submission.update_search()
                     add_ct += 1
             logger.info(f'{remove_ct} submissions removed from {prov._id}')
             logger.info(f'{add_ct} submissions synced to {prov._id}')