Merge pull request #240 from bp-cos/feature/fixed-a-test

feat(test-fixes): fixed a test

Author: bp-cos

.husky/pre-push

@@ -1,11 +1,11 @@
 # npm run build
 
-# npm run test:coverage || {
-#   printf "\n\nERROR: Testing errors or coverage issues were found. Please address them before proceeding.\n\n\n\n"
-#   exit 1
-# }
+npm run test:coverage || {
+  printf "\n\nERROR: Testing errors or coverage issues were found. Please address them before proceeding.\n\n\n\n"
+  exit 1
+}
 
-# npm run test:check-coverage-thresholds || {
-#   printf "\n\nERROR: Coverage thresholds were not met. Please address them before proceeding.\n\n\n\n"
-#   exit 1
-# }
+npm run test:check-coverage-thresholds || {
+  printf "\n\nERROR: Coverage thresholds were not met. Please address them before proceeding.\n\n\n\n"
+  exit 1
+}

jest.config.js

@@ -40,10 +40,10 @@ module.exports = {
   extensionsToTreatAsEsm: ['.ts'],
   coverageThreshold: {
     global: {
-      branches: 11.2,
-      functions: 11.34,
-      lines: 36.73,
-      statements: 37.33,
+      branches: 13.84,
+      functions: 14.33,
+      lines: 40.35,
+      statements: 40.9,
     },
   },
   testPathIgnorePatterns: [

src/app/core/components/request-access/request-access.component.spec.ts

@@ -1,3 +1,5 @@
+import { Store } from '@ngxs/store';
+
 import { TranslatePipe } from '@ngx-translate/core';
 import { MockPipe, MockProvider } from 'ng-mocks';
 
@@ -12,10 +14,17 @@ import { ToastService } from '@osf/shared/services';
 
 import { RequestAccessComponent } from './request-access.component';
 
-describe('RequestAccessComponent', () => {
+describe.only('RequestAccessComponent', () => {
   let component: RequestAccessComponent;
   let fixture: ComponentFixture<RequestAccessComponent>;
 
+  const mockStore: jest.Mocked<Store> = {
+    dispatch: jest.fn().mockResolvedValue(undefined) as any,
+    select: jest.fn().mockReturnValue(of(undefined)) as any,
+    selectSnapshot: jest.fn() as any,
+    reset: jest.fn() as any,
+  } as any;
+
   beforeEach(async () => {
     await TestBed.configureTestingModule({
       imports: [RequestAccessComponent, MockPipe(TranslatePipe)],
@@ -27,6 +36,8 @@ describe('RequestAccessComponent', () => {
       ],
     }).compileComponents();
 
+    TestBed.overrideProvider(Store, { useValue: mockStore });
+
     fixture = TestBed.createComponent(RequestAccessComponent);
     component = fixture.componentInstance;
     fixture.detectChanges();