Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

event sent metric tag missing due to timing issue when map record is added and read #79

Closed
yb01 opened this issue Jul 13, 2022 · 2 comments
Closed

event sent metric tag missing due to timing issue when map record is added and read #79

yb01 opened this issue Jul 13, 2022 · 2 comments

Comments

@yb01
Copy link
Collaborator

yb01 commented Jul 13, 2022 •
edited
Loading 

E0713 08:11:15.490648   43484 event_metrics.go:69] Event (MODIFIED, Id 33e882ef-c023-4319-9bca-c1cde26a2dce, RV 5049) does not have DIS_SENT stamped
E0713 08:11:15.492364   43484 event_metrics.go:69] Event (MODIFIED, Id 4f75716f-69f6-4833-98bb-1266d0539af0, RV 5050) does not have DIS_SENT stamped
E0713 08:11:15.494123   43484 event_metrics.go:69] Event (MODIFIED, Id d7662f86-c611-43ce-847d-a47860022c65, RV 5049) does not have DIS_SENT stamped
E0713 08:11:15.496405   43484 event_metrics.go:69] Event (MODIFIED, Id 97578d22-580c-4d0c-8f41-0bd5e3e35547, RV 5050) does not have DIS_SENT stamped
E0713 08:11:15.514868   43484 event_metrics.go:69] Event (MODIFIED, Id ae0be0e0-769c-4483-8845-d1aad8184d5b, RV 5048) does not have DIS_SENT stamped
@yb01 yb01 changed the title event sent metric tag missing -- likely related with event GCed while its pointer is sent to the channel -- event sent metric tag missing due to timing issue when map record is added and read Jul 13, 2022
yb01 referenced this issue in yb01/global-resource-service-release0.1 Jul 13, 2022
@yb01
fix issue #79 and #80
3505b3a
@yb01 yb01 mentioned this issue Jul 13, 2022
Merged
@yb01
Copy link
Collaborator Author

yb01 commented Jul 13, 2022

this is a timing issue when accessing the metircs map, as shown in below log:

root@ip-172-31-10-115:/work/src/global-resource-service/resource-management# grep 4b81b4a1-097e-4267-8490-748abe2d0f3c t.log
I0713 22:21:52.417250    6774 eventqueue.go:176] Sending event with node id 4b81b4a1-097e-4267-8490-748abe2d0f3c
I0713 22:21:52.420323    6774 installer.go:223] Getting event from distributor, node Id: 4b81b4a1-097e-4267-8490-748abe2d0f3c
E0713 22:21:52.420370    6774 event_metrics.go:69] Event (MODIFIED, Id 4b81b4a1-097e-4267-8490-748abe2d0f3c, RV 5001) does not have DIS_SENT stamped
I0713 22:21:52.420418    6774 eventqueue.go:180] Event with node id 4b81b4a1-097e-4267-8490-748abe2d0f3c sent
I0713 22:24:52.632423    6774 eventqueue.go:176] Sending event with node id 4b81b4a1-097e-4267-8490-748abe2d0f3c
I0713 22:24:52.632433    6774 eventqueue.go:180] Event with node id 4b81b4a1-097e-4267-8490-748abe2d0f3c sent
I0713 22:24:52.634457    6774 installer.go:223] Getting event from distributor, node Id: 4b81b4a1-097e-4267-8490-748abe2d0f3c
I0713 22:28:52.557469    6774 eventqueue.go:176] Sending event with node id 4b81b4a1-097e-4267-8490-748abe2d0f3c
I0713 22:28:52.557477    6774 eventqueue.go:180] Event with node id 4b81b4a1-097e-4267-8490-748abe2d0f3c sent
I0713 22:28:52.560322    6774 installer.go:223] Getting event from distributor, node Id: 4b81b4a1-097e-4267-8490-748abe2d0f3c
I0713 22:31:52.808413    6774 eventqueue.go:176] Sending event with node id 4b81b4a1-097e-4267-8490-748abe2d0f3c
I0713 22:31:52.808423    6774 eventqueue.go:180] Event with node id 4b81b4a1-097e-4267-8490-748abe2d0f3c sent
I0713 22:31:52.810683    6774 installer.go:223] Getting event from distributor, node Id: 4b81b4a1-097e-4267-8490-748abe2d0f3c
I0713 22:45:53.159112    6774 eventqueue.go:176] Sending event with node id 4b81b4a1-097e-4267-8490-748abe2d0f3c
I0713 22:45:53.159127    6774 eventqueue.go:180] Event with node id 4b81b4a1-097e-4267-8490-748abe2d0f3c sent
I0713 22:45:53.162808    6774 installer.go:223] Getting event from distributor, node Id: 4b81b4a1-097e-4267-8490-748abe2d0f3c
root@ip-172-31-10-115:/work/src/global-resource-service/resource-management#

yb01 added a commit that referenced this issue Jul 14, 2022
@yb01
fix issue 80 (#85)
a0a77d6 
* periodically dump event metrics

* fix issue #79 and #80

* fix typo
@yb01
Copy link
Collaborator Author

yb01 commented Jul 18, 2022

fixed in PR 85

@yb01 yb01 closed this as completed Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yb01