Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service_api.go triggers aggregator error: Get "http:///resources/initpull": http: no Host in request URL #103

Closed
sonyafenge opened this issue Jul 26, 2022 · 4 comments
Assignees
Milestone

Comments

@sonyafenge
Copy link
Collaborator

Repro steps:

  1. start service using the command below:
/usr/local/go/bin/go run resource-management/cmds/service-api/service-api.go  --master_ip=sonya-grs-server-us-central1-a-mig-mfl5 --resource_urls=34.168.53.159:9119,35.236.3.51:9119, -v=3  > ~/logs/sonya-grs-server-us-central1-a-mig-mfl5.log 2>&1
  1. if resource_urls has one more "," at the end of string(--resource_urls=34.168.53.159:9119,35.236.3.51:9119,), service logs keep display this error, if using "--resource_urls=34.168.53.159:9119,35.236.3.51:9119", error will not display.
E0726 03:47:18.686107    2134 aggregator.go:164] Get "http:///resources/initpull": http: no Host in request URL
  1. expected result: no error displayed
@yb01
Copy link
Collaborator

yb01 commented Jul 26, 2022

args need to be validated to trim any leading or trailing "," separators.

@yb01
Copy link
Collaborator

yb01 commented Jul 26, 2022

@sonyafenge , please verify.

@sonyafenge
Copy link
Collaborator Author

not a blocking for testing. open this issue, just want to suggest we add some basic error check in code to this kind of errors. close for now

@yb01 yb01 added this to the 2022-0930 milestone Jul 27, 2022
@yb01 yb01 reopened this Jul 27, 2022
@yb01 yb01 assigned q131172019 and unassigned sonyafenge Aug 8, 2022
@q131172019 q131172019 changed the title aggregator error: Get "http:///resources/initpull": http: no Host in request URL Service_api.go triggers aggregator error: Get "http:///resources/initpull": http: no Host in request URL Aug 9, 2022
@q131172019
Copy link
Collaborator

PR129 covers this issue.

@yb01 yb01 closed this as completed Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants