Merge pull request #96 from CatalystCode/thcao/iOS-tests

[iOS] Adding initial unit tests

Author: phongcao

azure-pipelines.yml

@@ -69,4 +69,20 @@ steps:
     xcWorkspacePath: '../sample/ios/ReactNativeAzureNotificationHubSample.xcworkspace'
     xcodeVersion: '10'
     signingOption: 'nosign'
-    useXcpretty: 'false'
+    useXcpretty: 'false'
+    
+- task: Xcode@5
+  displayName: 'Running iOS unit tests'
+  inputs:
+    actions: 'test'
+    scheme: 'ReactNativeAzureNotificationHubSample'
+    sdk: 'iphonesimulator'
+    configuration: 'Release'
+    xcWorkspacePath: '../sample/ios/ReactNativeAzureNotificationHubSample.xcworkspace'
+    xcodeVersion: '10'
+    signingOption: 'nosign'
+    useXcpretty: 'false'
+    destination: 'platform=iOS Simulator, name=iPhone 8'
+    destinationPlatformOption: 'iOS'
+    destinationTypeOption: 'simulators'
+    destinationSimulators: 'iPhone 8'

docs/android-installation.md

@@ -5,7 +5,7 @@
 The documentation that follows assumes you have generated a React Native Android project using the `react-native-cli`, i.e.:
 
 ```
-react-native init myapp
+react-native init ReactNativeAzureNotificationHubSample
 ```
 
 In addition to the standard React Native requirements, you will also need to install the following Android SDK components with your prefered SDK management tools:
@@ -193,7 +193,7 @@ const channelShowBadge = true;
 const channelEnableLights = true;
 const channelEnableVibration = true;
 
-class myapp extends Component {
+export default class App extends Component {
   constructor(props) {
     super(props);
     PushNotificationEmitter.addListener(DEVICE_NOTIF_EVENT, this._onRemoteNotification);

ios/RCTAzureNotificationHubManager/RCTAzureNotificationHubManager.h

@@ -26,4 +26,14 @@
 // Required for the registrationError event, invoked from AppDelegate
 + (void)didFailToRegisterForRemoteNotificationsWithError:(NSError *)error;
 
+// Register with Azure Notification Hub
+- (void)register:(nonnull NSString *)deviceToken
+          config:(nonnull NSDictionary *)config
+        resolver:(nonnull RCTPromiseResolveBlock)resolve
+        rejecter:(nonnull RCTPromiseRejectBlock)reject;
+
+// Unregister with Azure Notification Hub
+- (void)unregister:(nonnull RCTPromiseResolveBlock)resolve
+          rejecter:(nonnull RCTPromiseRejectBlock)reject;
+
 @end

sample/ios/Podfile

@@ -37,7 +37,8 @@ target 'ReactNativeAzureNotificationHubSample' do
 
   target 'ReactNativeAzureNotificationHubSampleTests' do
     inherit! :search_paths
-    # Pods for testing
+    use_frameworks!
+    pod 'OCMockito', '~> 5.0'
   end
 
   use_native_modules!

sample/ios/ReactNativeAzureNotificationHubSampleTests/ReactNativeAzureNotificationHubSampleTests.m

@@ -5,68 +5,80 @@
  * LICENSE file in the root directory of this source tree.
  */
 
-#import <UIKit/UIKit.h>
 #import <XCTest/XCTest.h>
+#import <RNAzureNotificationHub/RCTAzureNotificationHubManager.h>
 
-#import <React/RCTLog.h>
-#import <React/RCTRootView.h>
-
-#define TIMEOUT_SECONDS 600
-#define TEXT_TO_LOOK_FOR @"Welcome to React"
+@import OCMockito;
 
 @interface ReactNativeAzureNotificationHubSampleTests : XCTestCase
-
 @end
 
 @implementation ReactNativeAzureNotificationHubSampleTests
+{
+  RCTAzureNotificationHubManager *hubManager;
+  NSMutableDictionary *config;
+  RCTPromiseResolveBlock resolver;
+  RCTPromiseRejectBlock rejecter;
+}
 
-- (BOOL)findSubviewInView:(UIView *)view matching:(BOOL(^)(UIView *view))test
+- (void)setUp
 {
-  if (test(view)) {
-    return YES;
-  }
-  for (UIView *subview in [view subviews]) {
-    if ([self findSubviewInView:subview matching:test]) {
-      return YES;
-    }
-  }
-  return NO;
+  [super setUp];
+  hubManager = [[RCTAzureNotificationHubManager alloc] init];
+  config = [[NSMutableDictionary alloc] init];
+  resolver = ^(id result) {};
+  rejecter = ^(NSString *code, NSString *message, NSError *error) {};
 }
 
-- (void)testRendersWelcomeScreen
+- (void)testRegisterNoConnectionString
 {
-  UIViewController *vc = [[[RCTSharedApplication() delegate] window] rootViewController];
-  NSDate *date = [NSDate dateWithTimeIntervalSinceNow:TIMEOUT_SECONDS];
-  BOOL foundElement = NO;
+  __block NSString *errorMsg;
+  rejecter = ^(NSString *code, NSString *message, NSError *error)
+  {
+    errorMsg = message;
+  };
 
-  __block NSString *redboxError = nil;
-#ifdef DEBUG
-  RCTSetLogFunction(^(RCTLogLevel level, RCTLogSource source, NSString *fileName, NSNumber *lineNumber, NSString *message) {
-    if (level >= RCTLogLevelError) {
-      redboxError = message;
-    }
-  });
-#endif
+  [hubManager register:@""
+                config:config
+              resolver:resolver
+              rejecter:rejecter];
 
-  while ([date timeIntervalSinceNow] > 0 && !foundElement && !redboxError) {
-    [[NSRunLoop mainRunLoop] runMode:NSDefaultRunLoopMode beforeDate:[NSDate dateWithTimeIntervalSinceNow:0.1]];
-    [[NSRunLoop mainRunLoop] runMode:NSRunLoopCommonModes beforeDate:[NSDate dateWithTimeIntervalSinceNow:0.1]];
+  XCTAssertEqualObjects(errorMsg, @"Connection string cannot be null.");
+}
 
-    foundElement = [self findSubviewInView:vc.view matching:^BOOL(UIView *view) {
-      if ([view.accessibilityLabel isEqualToString:TEXT_TO_LOOK_FOR]) {
-        return YES;
-      }
-      return NO;
-    }];
-  }
-  
-#ifdef DEBUG
-  RCTSetLogFunction(RCTDefaultLogFunction);
-#endif
+- (void)testRegisterNoHubName
+{
+  __block NSString *errorMsg;
+  rejecter = ^(NSString *code, NSString *message, NSError *error)
+  {
+    errorMsg = message;
+  };
 
-  XCTAssertNil(redboxError, @"RedBox error: %@", redboxError);
-  XCTAssertTrue(foundElement, @"Couldn't find element with text '%@' in %d seconds", TEXT_TO_LOOK_FOR, TIMEOUT_SECONDS);
+  [config setObject:@"Connection String" forKey:@"connectionString"];
+  [hubManager register:@""
+                config:config
+              resolver:resolver
+              rejecter:rejecter];
+
+  XCTAssertEqualObjects(errorMsg, @"Hub name cannot be null.");
 }
 
+- (void)testRegisterSuccessfully
+{
+  __block bool hasError = false;
+  rejecter = ^(NSString *code, NSString *message, NSError *error)
+  {
+    hasError = true;
+  };
+
+  [config setObject:@"Connection String" forKey:@"connectionString"];
+  [config setObject:@"Hub Name" forKey:@"hubName"];
+  [hubManager register:@""
+                config:config
+              resolver:resolver
+              rejecter:rejecter];
+
+  XCTAssertEqual(hasError, false);
+}
 
 @end