Pid diagram #9 #30
Merged
Pid diagram #9 #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added functionality for the fire valve and the quick disconnect. Not sure how to actually test if they work. XV valves might need some extra functionality, as the names should change based on which valves are currently being used. That's my interpretation, at least. If that is not the case, code them in as is.
Increased number of XV valves from 4 to 12
Rebase done!
Increased number of XV valves from 4 to 12
EliasJRH
requested changes
Nov 17, 2024
There was a problem hiding this comment.
After reviewing with propulsion, it seems like they'd much rather prefer having a second window pop-up rather than using a separate tab. It seems like you've already done work to getting a separate window open which is great.
I also believe that they will be providing us with a new P&ID diagram with room for sensor readings which they would also like to see displayed in the P&ID if possible. I'd still like to get this merged in however there are some imports that are missing and some merge conflicts to resolve. Do you think you can have a look?
EliasJRH
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9 Added PID Diagram with labels for each of the actuators shown on the pid diagram tab. There are some elements/valves(?) that do not have labels e.g. HV-01, since they aren't on the telemetry spec nor added in UI.