Skip to content

Commit f337cc3

Browse files
authored
Merge pull request #119 from Capstone-OpenStep/feature/#111-issue-detail-by-url
Refactor: Task status 조회시 MERGED 상태 조회 오류 수정
2 parents 0c39ca6 + f8cc920 commit f337cc3

File tree

1 file changed

+11
-1
lines changed

1 file changed

+11
-1
lines changed

src/main/java/com/chungang/capstone/openstep/domain/Github/service/GitHubStatusResolverServiceImpl.java

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,11 +54,21 @@ public TaskStatus resolveStatus(Task task, Member member) {
5454
return newStatus;
5555
}
5656

57+
// TaskStatus newStatus;
58+
// if (pr.mergedAt() != null) {
59+
// newStatus = TaskStatus.MERGED;
60+
// } else if (Objects.equals(pr.state(), "closed")) {
61+
// newStatus = TaskStatus.REJECTED;
62+
// } else if (gitHubRestService.hasReview(owner, repo, pr.number(), githubToken)) {
63+
// newStatus = TaskStatus.REVIEW;
64+
// } else {
65+
// newStatus = TaskStatus.PR; // PR 생성만 된 상태
66+
// }
5767
// 머지 or 반려 여부
5868
TaskStatus newStatus;
5969
if (pr.mergedAt() != null) {
6070
newStatus = TaskStatus.MERGED;
61-
} else if (Objects.equals(pr.state(), "closed")) {
71+
} else if (Objects.equals(pr.state(), "closed") && pr.mergedAt() == null) {
6272
newStatus = TaskStatus.REJECTED;
6373
} else if (gitHubRestService.hasReview(owner, repo, pr.number(), githubToken)) {
6474
newStatus = TaskStatus.REVIEW;

0 commit comments

Comments
 (0)