Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for calling destructor and then constructor #318

Open
jwallwork23 opened this issue Mar 10, 2025 · 0 comments · May be fixed by #319
Open

Tests for calling destructor and then constructor #318

jwallwork23 opened this issue Mar 10, 2025 · 0 comments · May be fixed by #319
Assignees
@jwallwork23
Labels
testing Related to FTorch testing

Comments

@jwallwork23
Copy link
Collaborator

We have unit tests that check that the torch_tensor_delete destructor works when called manually or automatically via the finalizer. However, we do not consider the case where a user calls the destructor and then applies a constructor to the same tensor. @ma595 showed an example where this could happen in a loop over vertical levels, for example.
@jwallwork23 jwallwork23 added the testing Related to FTorch testing label Mar 10, 2025
@jwallwork23 jwallwork23 self-assigned this Mar 10, 2025
@jwallwork23 jwallwork23 linked a pull request Mar 10, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jwallwork23 jwallwork23

Labels
testing Related to FTorch testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add tests for constructing after destructing Cambridge-ICCS/FTorch
1 participant
@jwallwork23