-
Notifications
You must be signed in to change notification settings - Fork 50
Vault: withdraw event parity with EVENT_SCHEMA.md #157
Copy link
Copy link
Open
Labels
Stellar WaveIssues in the Stellar wave programIssues in the Stellar wave programsecuritysmart-contractssorobanvault
Description
Description
Emit withdraw / withdraw_to events with topics/data exactly as documented; add tests where possible.
Requirements and context
- Fix drift between docs and implementation.
- Ensure owner-only auth remains intact.
Suggested execution
- Fork the repo and create a branch:
git checkout -b feature/vault-withdraw-events - Implement changes in the Callora-Contracts Soroban workspace (
contracts/*/src/). - Run
cargo fmt,cargo clippy --all-targets --all-features -- -D warnings, andcargo testfrom the workspace root. - For WASM release builds:
cargo build --target wasm32-unknown-unknown --release -p callora-vault(adjust-pif the crate name differs).
Deliverables
lib.rs+test.rs+EVENT_SCHEMA.md.
Test and commit
- Run tests and
./scripts/coverage.sh(orcargo tarpaulinpertarpaulin.toml). - Cover edge cases; include summarized test output and brief security notes in the PR description.
Example commit message
feat(vault): withdraw event parity with schema
Guidelines
- Minimum 95% line coverage for touched crates (workspace policy).
- Clear documentation (Rust
///on public items where applicable; repo markdown as needed). - Timeframe: 96 hours from assignment unless agreed otherwise.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Stellar WaveIssues in the Stellar wave programIssues in the Stellar wave programsecuritysmart-contractssorobanvault