Skip to content

Settlement: standardize unauthorized panic strings + tests #149

@greatest0fallt1me

Description

@greatest0fallt1me

Description

Align unauthorized: caller must be vault or admin messaging across entrypoints; update tests accordingly.

Requirements and context

  • No intentional behavior changes unless a bug is discovered.
  • Improve supportability.

Suggested execution

  • Fork the repo and create a branch: git checkout -b chore/settlement-errors
  • Implement changes in the Callora-Contracts Soroban workspace (contracts/*/src/).
  • Run cargo fmt, cargo clippy --all-targets --all-features -- -D warnings, and cargo test from the workspace root.
  • For WASM release builds: cargo build --target wasm32-unknown-unknown --release -p callora-settlement (adjust -p if the crate name differs).

Deliverables

  • lib.rs + test.rs.

Test and commit

  • Run tests and ./scripts/coverage.sh (or cargo tarpaulin per tarpaulin.toml).
  • Cover edge cases; include summarized test output and brief security notes in the PR description.

Example commit message

chore(settlement): standardize panic strings

Guidelines

  • Minimum 95% line coverage for touched crates (workspace policy).
  • Clear documentation (Rust /// on public items where applicable; repo markdown as needed).
  • Timeframe: 96 hours from assignment unless agreed otherwise.

Metadata

Metadata

Assignees

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions