Skip to content

Workspace: fix duplicate [workspace].members in root Cargo.toml #118

@greatest0fallt1me

Description

@greatest0fallt1me

Description

Ensure the workspace includes vault, revenue_pool, and settlement exactly once each (as product intends) and cargo metadata succeeds.

Requirements and context

  • CI must use a coherent workspace graph.
  • Update README layout tree if needed.

Suggested execution

  • Fork the repo and create a branch: git checkout -b fix/workspace-cargo-members
  • Implement changes in the Callora-Contracts Soroban workspace (contracts/*/src/).
  • Run cargo fmt, cargo clippy --all-targets --all-features -- -D warnings, and cargo test from the workspace root.
  • For WASM release builds: cargo build --target wasm32-unknown-unknown --release -p callora-vault (adjust -p if the crate name differs).

Deliverables

  • Edit Callora-Contracts/Cargo.toml.
  • Run cargo test --workspace.

Test and commit

  • Run tests and ./scripts/coverage.sh (or cargo tarpaulin per tarpaulin.toml).
  • Cover edge cases; include summarized test output and brief security notes in the PR description.

Example commit message

fix(workspace): correct Cargo workspace members list

Guidelines

  • Minimum 95% line coverage for touched crates (workspace policy).
  • Clear documentation (Rust /// on public items where applicable; repo markdown as needed).
  • Timeframe: 96 hours from assignment unless agreed otherwise.

Metadata

Metadata

Assignees

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions