Skip to content

Commit c20757e

Browse files
committed
Fix phpcs and stan
1 parent 25b0ec5 commit c20757e

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

src/Webauthn/Base64Utility.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
class Base64Utility
2323
{
2424
/**
25-
* @param string $data
25+
* @param string $data The data to encode
2626
* @return string
2727
*/
2828
public static function complyEncodedNoPadding(string $data): string

src/Webauthn/BaseAdapter.php

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
use Cake\Utility\Hash;
2020
use CakeDC\Api\Utility\RequestParser;
2121
use CakeDC\Api\Webauthn\Repository\UserCredentialSourceRepository;
22+
use CakeDC\Users\Model\Table\UsersTable;
2223
use Cose\Algorithm\Manager;
2324
use Cose\Algorithm\Signature\ECDSA\ES256;
2425
use Cose\Algorithm\Signature\ECDSA\ES256K;
@@ -36,7 +37,6 @@
3637
use Webauthn\AttestationStatement\AttestationStatementSupportManager;
3738
use Webauthn\AttestationStatement\NoneAttestationStatementSupport;
3839
use Webauthn\AuthenticationExtensions\ExtensionOutputCheckerHandler;
39-
use CakeDC\Users\Model\Table\UsersTable;
4040
use Webauthn\PublicKeyCredentialRpEntity;
4141
use Webauthn\PublicKeyCredentialUserEntity;
4242

@@ -252,7 +252,8 @@ public function getDomain($replace = true)
252252
}
253253

254254
/**
255-
* @param \Webauthn\AttestationStatement\AttestationStatementSupportManager $attestationStatementSupportManager
255+
* @param \Webauthn\AttestationStatement\AttestationStatementSupportManager $attestationStatementSupportManager manager instance
256+
* @return void
256257
*/
257258
public function setAttestationStatementSupportManager(
258259
AttestationStatementSupportManager $attestationStatementSupportManager
@@ -275,7 +276,7 @@ protected function getAttestationStatementSupportManager(): AttestationStatement
275276
}
276277

277278
/**
278-
* @return \CakeDC\Users\Webauthn\PublicKeyCredentialLoader
279+
* @return \CakeDC\Api\Webauthn\PublicKeyCredentialLoader
279280
*/
280281
protected function createPublicKeyCredentialLoader(): PublicKeyCredentialLoader
281282
{

src/Webauthn/RegisterAdapter.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
use Webauthn\PublicKeyCredentialCreationOptions;
2222
use Webauthn\PublicKeyCredentialDescriptor;
2323
use Webauthn\PublicKeyCredentialParameters;
24+
use Webauthn\PublicKeyCredentialSource;
2425

2526
class RegisterAdapter extends BaseAdapter
2627
{
@@ -71,7 +72,7 @@ protected function getPubKeyCredParams(): array
7172
*
7273
* @return \Webauthn\PublicKeyCredentialSource
7374
*/
74-
public function verifyResponse(): \Webauthn\PublicKeyCredentialSource
75+
public function verifyResponse(): PublicKeyCredentialSource
7576
{
7677
$storeEntity = $this->readStore();
7778
$options = $this->getStore($storeEntity, 'registerOptions');

src/Webauthn/Repository/UserCredentialSourceRepository.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,12 +60,10 @@ public function findOneByCredentialId(string $publicKeyCredentialId): ?PublicKey
6060
*/
6161
public function findAllForUserEntity(PublicKeyCredentialUserEntity $publicKeyCredentialUserEntity): array
6262
{
63-
if ($publicKeyCredentialUserEntity->getId() != $this->user->id) {
63+
if ($publicKeyCredentialUserEntity->getId() != $this->user->get('id')) {
6464
return [];
6565
}
66-
\Cake\Log\Log::error(print_r($this->user, true));
6766
$credentials = $this->getUserData($this->user);
68-
\Cake\Log\Log::error(print_r($credentials, true));
6967

7068
$list = [];
7169
foreach ($credentials as $credential) {

0 commit comments

Comments
 (0)