From eac2c7f91779e610bfd4bae0210687de1aeaa6c0 Mon Sep 17 00:00:00 2001 From: Francisco Herrera Date: Tue, 20 Jan 2026 18:23:20 -0500 Subject: [PATCH 1/9] Enhance error message I have found the minimum size required to be 2 gb. Also grammar fix --- src/modules/partition/gui/ChoicePage.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/modules/partition/gui/ChoicePage.cpp b/src/modules/partition/gui/ChoicePage.cpp index 0fac14f3ba..2814a3726f 100644 --- a/src/modules/partition/gui/ChoicePage.cpp +++ b/src/modules/partition/gui/ChoicePage.cpp @@ -1253,7 +1253,8 @@ ChoicePage::setupEfiSystemPartitionSelector() if ( !PartUtils::isEfiFilesystemRecommendedSize( efiPartition ) ) { text += QStringLiteral( "
" ) - + tr( "The EFI system partition is too small, please use manual partition." ) + + tr( "The EFI system partition is too small, please use manual partitioning + and increase its size to 2 GB or greater." ) + QStringLiteral( "" ); } m_efiLabel->setText( text ); From ab10b304c748a9b5e9690130834109cb3ee0635c Mon Sep 17 00:00:00 2001 From: Francisco Herrera Date: Tue, 20 Jan 2026 18:26:58 -0500 Subject: [PATCH 2/9] Grammar fix --- src/modules/partition/gui/ChoicePage.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/partition/gui/ChoicePage.cpp b/src/modules/partition/gui/ChoicePage.cpp index 2814a3726f..e9ab33abb5 100644 --- a/src/modules/partition/gui/ChoicePage.cpp +++ b/src/modules/partition/gui/ChoicePage.cpp @@ -1253,7 +1253,7 @@ ChoicePage::setupEfiSystemPartitionSelector() if ( !PartUtils::isEfiFilesystemRecommendedSize( efiPartition ) ) { text += QStringLiteral( "
" ) - + tr( "The EFI system partition is too small, please use manual partitioning + + tr( "The EFI system partition is too small, please select manual partitioning and increase its size to 2 GB or greater." ) + QStringLiteral( "" ); } From 3a45f735d198e74649a226c4a5524db390a82eef Mon Sep 17 00:00:00 2001 From: Francisco Herrera Date: Wed, 21 Jan 2026 19:01:03 -0500 Subject: [PATCH 3/9] Increase to 4 gb --- src/modules/partition/gui/ChoicePage.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/partition/gui/ChoicePage.cpp b/src/modules/partition/gui/ChoicePage.cpp index e9ab33abb5..1ce71645cf 100644 --- a/src/modules/partition/gui/ChoicePage.cpp +++ b/src/modules/partition/gui/ChoicePage.cpp @@ -1254,7 +1254,7 @@ ChoicePage::setupEfiSystemPartitionSelector() { text += QStringLiteral( "
" ) + tr( "The EFI system partition is too small, please select manual partitioning - and increase its size to 2 GB or greater." ) + and increase its size to 4 GB or greater." ) + QStringLiteral( "" ); } m_efiLabel->setText( text ); From 2e733cc99177475f08e804abd00607dea77b9ba8 Mon Sep 17 00:00:00 2001 From: Francisco Herrera Date: Sat, 25 Apr 2026 19:53:27 -0500 Subject: [PATCH 4/9] query recommended size --- src/modules/partition/gui/ChoicePage.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/modules/partition/gui/ChoicePage.cpp b/src/modules/partition/gui/ChoicePage.cpp index 1ce71645cf..c6b2aacd94 100644 --- a/src/modules/partition/gui/ChoicePage.cpp +++ b/src/modules/partition/gui/ChoicePage.cpp @@ -1253,8 +1253,9 @@ ChoicePage::setupEfiSystemPartitionSelector() if ( !PartUtils::isEfiFilesystemRecommendedSize( efiPartition ) ) { text += QStringLiteral( "
" ) - + tr( "The EFI system partition is too small, please select manual partitioning - and increase its size to 4 GB or greater." ) + + tr( "The EFI system partition is too small, please use manual partition ", + "and increase its size to %1 MB or greater") + .arg(PartUtils::efiFilesystemRecommendedSize() / 1024 / 1024) + QStringLiteral( "" ); } m_efiLabel->setText( text ); From 23f7c626df6c1a9976e755f6a0af0993fc20ec8e Mon Sep 17 00:00:00 2001 From: Francisco Herrera Date: Sat, 25 Apr 2026 19:56:20 -0500 Subject: [PATCH 5/9] grammar fix --- src/modules/partition/gui/ChoicePage.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/partition/gui/ChoicePage.cpp b/src/modules/partition/gui/ChoicePage.cpp index c6b2aacd94..e9afe6ce24 100644 --- a/src/modules/partition/gui/ChoicePage.cpp +++ b/src/modules/partition/gui/ChoicePage.cpp @@ -1253,7 +1253,7 @@ ChoicePage::setupEfiSystemPartitionSelector() if ( !PartUtils::isEfiFilesystemRecommendedSize( efiPartition ) ) { text += QStringLiteral( "
" ) - + tr( "The EFI system partition is too small, please use manual partition ", + + tr( "The EFI system partition is too small, please use manual partitioning ", "and increase its size to %1 MB or greater") .arg(PartUtils::efiFilesystemRecommendedSize() / 1024 / 1024) + QStringLiteral( "" ); From 5824d51808a760c1bcbbe9bde06e7774e8ec0344 Mon Sep 17 00:00:00 2001 From: Francisco Herrera Date: Sat, 25 Apr 2026 19:58:14 -0500 Subject: [PATCH 6/9] wording fix --- src/modules/partition/gui/ChoicePage.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/partition/gui/ChoicePage.cpp b/src/modules/partition/gui/ChoicePage.cpp index e9afe6ce24..d8f01f1f17 100644 --- a/src/modules/partition/gui/ChoicePage.cpp +++ b/src/modules/partition/gui/ChoicePage.cpp @@ -1253,7 +1253,7 @@ ChoicePage::setupEfiSystemPartitionSelector() if ( !PartUtils::isEfiFilesystemRecommendedSize( efiPartition ) ) { text += QStringLiteral( "
" ) - + tr( "The EFI system partition is too small, please use manual partitioning ", + + tr( "The EFI system partition is too small, please select manual partitioning ", "and increase its size to %1 MB or greater") .arg(PartUtils::efiFilesystemRecommendedSize() / 1024 / 1024) + QStringLiteral( "" ); From 911a74e7db54b721fe40d5f47853adfac46643ce Mon Sep 17 00:00:00 2001 From: Peter Jung Date: Sun, 24 May 2026 20:36:11 +0200 Subject: [PATCH 7/9] Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --- src/modules/partition/gui/ChoicePage.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/modules/partition/gui/ChoicePage.cpp b/src/modules/partition/gui/ChoicePage.cpp index d8f01f1f17..58643d885e 100644 --- a/src/modules/partition/gui/ChoicePage.cpp +++ b/src/modules/partition/gui/ChoicePage.cpp @@ -1254,8 +1254,8 @@ ChoicePage::setupEfiSystemPartitionSelector() { text += QStringLiteral( "
" ) + tr( "The EFI system partition is too small, please select manual partitioning ", - "and increase its size to %1 MB or greater") - .arg(PartUtils::efiFilesystemRecommendedSize() / 1024 / 1024) + "and increase its size to %1 MiB or greater" ) + .arg( Calamares::BytesToMiB( PartUtils::efiFilesystemRecommendedSize() ) ) + QStringLiteral( "" ); } m_efiLabel->setText( text ); From c664bbdd5a6c0eda06803416cf18b39e66da7727 Mon Sep 17 00:00:00 2001 From: Francisco Herrera Date: Mon, 25 May 2026 00:55:14 -0500 Subject: [PATCH 8/9] Implement copilot suggestion --- src/modules/partition/gui/ChoicePage.cpp | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/modules/partition/gui/ChoicePage.cpp b/src/modules/partition/gui/ChoicePage.cpp index 58643d885e..91c3d869fa 100644 --- a/src/modules/partition/gui/ChoicePage.cpp +++ b/src/modules/partition/gui/ChoicePage.cpp @@ -1253,10 +1253,11 @@ ChoicePage::setupEfiSystemPartitionSelector() if ( !PartUtils::isEfiFilesystemRecommendedSize( efiPartition ) ) { text += QStringLiteral( "
" ) - + tr( "The EFI system partition is too small, please select manual partitioning ", - "and increase its size to %1 MiB or greater" ) - .arg( Calamares::BytesToMiB( PartUtils::efiFilesystemRecommendedSize() ) ) - + QStringLiteral( "" ); + + tr( "The EFI system partition is too small, please select manual partitioning " + "and increase its size to %1 MB or greater.", + "@info, %1 is the recommended EFI system partition size in MB" ) + .arg( PartUtils::efiFilesystemRecommendedSize() / 1024 / 1024 ) + + QStringLiteral( "" ); } m_efiLabel->setText( text ); } From feae204748fe18b69a1144d407027d2b3e90ec1e Mon Sep 17 00:00:00 2001 From: Francisco Herrera Date: Mon, 25 May 2026 00:58:15 -0500 Subject: [PATCH 9/9] Fix ident --- src/modules/partition/gui/ChoicePage.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/partition/gui/ChoicePage.cpp b/src/modules/partition/gui/ChoicePage.cpp index 91c3d869fa..ad14563e05 100644 --- a/src/modules/partition/gui/ChoicePage.cpp +++ b/src/modules/partition/gui/ChoicePage.cpp @@ -1257,7 +1257,7 @@ ChoicePage::setupEfiSystemPartitionSelector() "and increase its size to %1 MB or greater.", "@info, %1 is the recommended EFI system partition size in MB" ) .arg( PartUtils::efiFilesystemRecommendedSize() / 1024 / 1024 ) - + QStringLiteral( "" ); + + QStringLiteral( "" ); } m_efiLabel->setText( text ); }