Currently, we don't print the BestResult if the region timeout is 0:
|
if (rgnTimeout != 0) { |
|
bool optimalSchedule = isLstOptml || (rslt == RES_SUCCESS); |
|
Logger::Event("BestResult", "name", dataDepGraph_->GetDagID(), // |
|
"cost", bestCost_, "length", bestSchedLngth_, // |
|
"optimal", optimalSchedule); |
|
// TODO(justin): Remove once relevant scripts have been updated: |
|
// get-sched-length.py, plaidbench-validation-test.py |
|
Logger::Info("Best schedule for DAG %s has cost %d and length %d. The " |
|
"schedule is %s", |
|
dataDepGraph_->GetDagID(), bestCost_, bestSchedLngth_, |
|
optimalSchedule ? "optimal" : "not optimal"); |
|
} |
However, region timeouts of 0 can be used to bypass our scheduler. We should still print the BestResult; it should just use the heuristic schedule. Not having the BestResult confuses the validation-test script.
This is not as simple as removing the condition, however, as the optimalSchedule logic must also be updated.
Currently, we don't print the BestResult if the region timeout is 0:
OptSched/lib/Scheduler/sched_region.cpp
Lines 563 to 574 in 43931a1
However, region timeouts of 0 can be used to bypass our scheduler. We should still print the BestResult; it should just use the heuristic schedule. Not having the BestResult confuses the validation-test script.
This is not as simple as removing the condition, however, as the
optimalSchedulelogic must also be updated.