mod crashed with yes steve model

[veccyboi]

Description

sorry to bring another issue to your attention so soon. i can confirm that the most recent build did indeed fix issues #62 and #84; thank you for the swift fixing; your work is greatly appreciated. however, i have discovered yet another one:

i was screwing around with this mod: https://modrinth.com/mod/yes-steve-model, that changes the player model. everything was fine for a while until i tried to import a large number of models, at which point, the game crashed. now, i cannot load into any worlds with placed pipes; they instantly crash with the below report. removing YSM removes the issue, and adding it back brings back the issue, so it is definitely correlated. i have reported this same bug to their github, but I am also reporting it here as the crash ultimately seems to be a CSOS rendering issue not unlike the one seen in #76 , but not caused by world edit (in fact, I have always used world edit and CSOS with no problems).

the crash report attached mentions the chamade renderer, but the first time this happened, it was from the open wood renderer instead.

Game Log & Crash Report (if applicable)

https://mclo.gs/XlFDIWY

Debug Information

Client Info

Create:
	Mod Version: 6.0.8
	Mod Git Commit: 1a1a9a2819b4f89f78caec41b55ed8cb222fa24b
	Ponder Version: 1.0.91
	Forge Version: 47.4.0
	Minecraft Version: 1.20.1

Graphics:
	Flywheel Version: 1.0.5
	Flywheel Backend: flywheel:indirect
	OpenGL Renderer: NVIDIA GeForce RTX 5060 Laptop GPU/PCIe/SSE2
	OpenGL Version: 4.6.0 NVIDIA 591.86
	Graphics Mode: fancy
	PojavLauncher Detected: false

System Information:
	Operating System: Windows 11 (amd64) version 10.0
	Java Version: 21.0.7, Red Hat, Inc.
	JVM Flags: 9 total; -XX:+UseShenandoahGC -XX:+UnlockExperimentalVMOptions -XX:+AlwaysPreTouch -XX:+UseStringDeduplication -XX:-OmitStackTraceInFastThrow -XX:+OptimizeStringConcat -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xms18432m -Xmx18432m
	Memory: 16748178536 bytes (15972 MiB) / 19327352832 bytes (18432 MiB) up to 19327352832 bytes (18432 MiB)
	Total Memory: 2592582992 bytes (2472 MiB) / 19327352832 bytes (18432 MiB)
	CPU: Intel(R) Core(TM) Ultra 9 275HX @ 3.07 GHz; 24 cores / 24 threads on 1 socket(s)
	Graphics card #0: NVIDIA GeForce RTX 5060 Laptop GPU (NVIDIA (0x10de)); 4095.00 MB of VRAM
	Graphics card #1: Intel(R) Graphics (Intel Corporation (0x8086)); 2048.00 MB of VRAM

Other Mods:
	Timeless & Classics Guns: Zero: 1.1.7-hotfix
	Yes Steve Model: 2.6.2-forge+mc1.20.1
	Create: Sound of Steam: 0.8.3+1.20.1

Server Info

Create:
	Mod Version: 6.0.8
	Mod Git Commit: 1a1a9a2819b4f89f78caec41b55ed8cb222fa24b
	Ponder Version: 1.0.91
	Forge Version: 47.4.0
	Minecraft Version: 1.20.1

System Information:
	Operating System: Windows 11 (amd64) version 10.0
	Java Version: 21.0.7, Red Hat, Inc.
	JVM Flags: 9 total; -XX:+UseShenandoahGC -XX:+UnlockExperimentalVMOptions -XX:+AlwaysPreTouch -XX:+UseStringDeduplication -XX:-OmitStackTraceInFastThrow -XX:+OptimizeStringConcat -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xms18432m -Xmx18432m
	Memory: 16748178536 bytes (15972 MiB) / 19327352832 bytes (18432 MiB) up to 19327352832 bytes (18432 MiB)
	Total Memory: 2592582992 bytes (2472 MiB) / 19327352832 bytes (18432 MiB)
	CPU: Intel(R) Core(TM) Ultra 9 275HX @ 3.07 GHz; 24 cores / 24 threads on 1 socket(s)
	Graphics card #0: NVIDIA GeForce RTX 5060 Laptop GPU (NVIDIA (0x10de)); 4095.00 MB of VRAM
	Graphics card #1: Intel(R) Graphics (Intel Corporation (0x8086)); 2048.00 MB of VRAM

Other Mods:
	Timeless & Classics Guns: Zero: 1.1.7-hotfix
	Yes Steve Model: 2.6.2-forge+mc1.20.1
	Create: Sound of Steam: 0.8.3+1.20.1

[veccyboi]

doing some of my own investigation I have found this old discord bug report https://discord.com/channels/1335536388203876383/1335540673570541568/threads/1374575106415661217 and issue #22 , which appear to have the same crash report but this time originating from TrompetteRenderer instead

it still remains that YSM precipitated or triggered the crash (as again, removing it makes everything fine) but it appears that this specific crash
com.google.common.util.concurrent.UncheckedExecutionException: java.lang.NullPointerException: Cannot invoke "net.minecraft.client.resources.model.BakedModel.getModelData(net.minecraft.world.level.BlockAndTintGetter, net.minecraft.core.BlockPos, net.minecraft.world.level.block.state.BlockState, net.minecraftforge.client.model.data.ModelData)" because "model" is null at com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2055) ~[guava-31.1-jre.jar%23109!/:?] {}

has happened a few times before, been thought to be fixed, and then reappeared

[Deanosaur75]

Ugh... not this again. Thanks for bringing it to our attention, though. We'll look into it

[veccyboi]

no problem
hopefully this accursed bug gets fixed once and for all

[veccyboi]

what is also really annoying about this bug is that it doesn't occur at first

only this one modpack seems to exhibit the crash; another modpack with the two together doesn't do anything.

the bugged modpack also initially was fine, then it randomly decided to be not fine, and nothing, including completely deleting and reinstalling every file related to either mod, has made it fine again.

the worst kind to debug

[TheAnonym3000]

I analyzed and looked at Code a little bit and came to the point that this has something to do with some cache/buffer. The main suspected Classes are all using buffers/caches:

 return cache.get(key, callable);

(https://github.com/Creators-of-Create/Ponder/blob/09e008a1406737d2a13beb7d36503a7e6d80258d/Common/src/main/java/net/createmod/catnip/render/SuperByteBufferCache.java#L43)

renderSafe(be, partialTicks, ms, bufferSource, light, overlay);

(https://github.com/Creators-of-Create/Create/blob/a9154c8b6cbe32b5eed8654189a6402d9a8ee1bd/src/main/java/com/simibubi/create/foundation/blockEntity/renderer/SafeBlockEntityRenderer.java#L24)

SoundOfSteam/src/main/java/com/finchy/pipeorgans/content/pipes/Chamade.java

Line 135 in 821ca42

CachedBuffers.partial(mouth, blockState)