Skip to content

Commit a3a02d8

Browse files
committed
libpressio version 0.56.0
Breaking Change + metrics now provide a default implementation of {begin,end}_{de,}compress_many which defaults to calling {begin,end}_{de,}compress. This eases some of the implementation of metrics that support being called from `_many` contexts + the default implementation of compress_many now calls compress_impl instead of compress.
1 parent 3af4b64 commit a3a02d8

4 files changed

Lines changed: 27 additions & 15 deletions

File tree

CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
cmake_minimum_required(VERSION 3.13 FATAL_ERROR)
2-
project(libpressio VERSION "0.55.3" LANGUAGES CXX C)
2+
project(libpressio VERSION "0.56.0" LANGUAGES CXX C)
33

44
#correct was to set a default build type
55
# https://blog.kitware.com/cmake-and-the-default-build-type/

COPYRIGHT.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Copyright © 2021 , UChicago Argonne, LLC
22
All Rights Reserved
3-
[libpressio, Version 0.55.3]
3+
[libpressio, Version 0.56.0]
44
Robert Underwood
55
Argonne National Laboratory
66

include/libpressio_ext/cpp/compressor.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,7 @@ class libpressio_compressor_plugin :public pressio_configurable, public pressio_
251251
virtual int decompress_many_impl(compat::span<const pressio_data* const> const& inputs, compat::span<pressio_data* >& outputs) {
252252
//default returns an error to indicate the option is unsupported;
253253
if(inputs.size() == 1 && outputs.size() == 1) {
254-
return decompress(inputs.front(), outputs.front());
254+
return decompress_impl(inputs.front(), outputs.front());
255255
} else
256256
return set_error(1, "decompress_many not supported");
257257
}
@@ -262,7 +262,7 @@ class libpressio_compressor_plugin :public pressio_configurable, public pressio_
262262
virtual int compress_many_impl(compat::span<const pressio_data* const> const& inputs, compat::span<pressio_data*> & outputs) {
263263
//default returns an error to indicate the option is unsupported;
264264
if(inputs.size() == 1 && outputs.size() == 1) {
265-
return compress(inputs.front(), outputs.front());
265+
return compress_impl(inputs.front(), outputs.front());
266266
} else
267267
return set_error(1, "decompress_many not supported");
268268
}

src/plugins/metrics/metrics_base.cc

Lines changed: 23 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -26,17 +26,29 @@ void libpressio_metrics_plugin::begin_decompress(struct pressio_data const*, pre
2626
}
2727
void libpressio_metrics_plugin::end_decompress(struct pressio_data const*, pressio_data const*, int) {
2828
}
29-
void libpressio_metrics_plugin::begin_compress_many(compat::span<const pressio_data* const> const&,
30-
compat::span<const pressio_data* const> const&) {
31-
}
32-
void libpressio_metrics_plugin::end_compress_many(compat::span<const pressio_data* const> const& ,
33-
compat::span<const pressio_data* const> const& , int ) {
34-
}
35-
void libpressio_metrics_plugin::begin_decompress_many(compat::span<const pressio_data* const> const& ,
36-
compat::span<const pressio_data* const> const& ) {
37-
}
38-
void libpressio_metrics_plugin::end_decompress_many(compat::span<const pressio_data* const> const&,
39-
compat::span<const pressio_data* const> const& , int) {
29+
void libpressio_metrics_plugin::begin_compress_many(compat::span<const pressio_data* const> const& inputs,
30+
compat::span<const pressio_data* const> const& outputs) {
31+
if(inputs.size() == 1 && outputs.size() == 1) {
32+
begin_compress(inputs.front(), outputs.front());
33+
}
34+
}
35+
void libpressio_metrics_plugin::end_compress_many(compat::span<const pressio_data* const> const& inputs,
36+
compat::span<const pressio_data* const> const& outputs, int rc) {
37+
if(inputs.size() == 1 && outputs.size() == 1) {
38+
end_compress(inputs.front(), outputs.front(), rc);
39+
}
40+
}
41+
void libpressio_metrics_plugin::begin_decompress_many(compat::span<const pressio_data* const> const& inputs,
42+
compat::span<const pressio_data* const> const& outputs) {
43+
if(inputs.size() == 1 && outputs.size() == 1) {
44+
begin_decompress(inputs.front(), outputs.front());
45+
}
46+
}
47+
void libpressio_metrics_plugin::end_decompress_many(compat::span<const pressio_data* const> const& inputs,
48+
compat::span<const pressio_data* const> const& outputs, int rc) {
49+
if(inputs.size() == 1 && outputs.size() == 1) {
50+
end_decompress(inputs.front(), outputs.front(), rc);
51+
}
4052
}
4153

4254
void libpressio_metrics_plugin::set_name(std::string const& new_name) {

0 commit comments

Comments
 (0)