Skip to content

Commit c55b0a3

Browse files
committed
Update tests
1 parent 4fb8898 commit c55b0a3

6 files changed

Lines changed: 36 additions & 6 deletions

File tree

reportbuilder/tests/local/aggregation/avg_test.php

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,12 @@ public function test_column_aggregation(): void {
5050
$report = $generator->create_report(['name' => 'Users', 'source' => users::class, 'default' => 0]);
5151

5252
// Report columns, aggregated/sorted by user suspended.
53-
$generator->create_column(['reportid' => $report->get('id'), 'uniqueidentifier' => 'user:firstname']);
53+
$generator->create_column([
54+
'reportid' => $report->get('id'),
55+
'uniqueidentifier' => 'user:firstname',
56+
'sortenabled' => 1,
57+
'sortdirection' => SORT_DESC,
58+
]);
5459
$generator->create_column([
5560
'reportid' => $report->get('id'),
5661
'uniqueidentifier' => 'user:suspended',

reportbuilder/tests/local/aggregation/count_test.php

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,12 @@ public function test_column_aggregation(): void {
4949
$report = $generator->create_report(['name' => 'Users', 'source' => users::class, 'default' => 0]);
5050

5151
// Report columns, aggregated/sorted by user lastname.
52-
$generator->create_column(['reportid' => $report->get('id'), 'uniqueidentifier' => 'user:firstname']);
52+
$generator->create_column([
53+
'reportid' => $report->get('id'),
54+
'uniqueidentifier' => 'user:firstname',
55+
'sortenabled' => 1,
56+
'sortdirection' => SORT_DESC,
57+
]);
5358
$generator->create_column([
5459
'reportid' => $report->get('id'),
5560
'uniqueidentifier' => 'user:lastname',

reportbuilder/tests/local/aggregation/max_test.php

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,12 @@ public function test_column_aggregation(): void {
5151
$report = $generator->create_report(['name' => 'Users', 'source' => users::class, 'default' => 0]);
5252

5353
// Report columns, aggregated/sorted by user suspended.
54-
$generator->create_column(['reportid' => $report->get('id'), 'uniqueidentifier' => 'user:firstname']);
54+
$generator->create_column([
55+
'reportid' => $report->get('id'),
56+
'uniqueidentifier' => 'user:firstname',
57+
'sortenabled' => 1,
58+
'sortdirection' => SORT_DESC,
59+
]);
5560
$generator->create_column([
5661
'reportid' => $report->get('id'),
5762
'uniqueidentifier' => 'user:suspended',

reportbuilder/tests/local/aggregation/min_test.php

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,12 @@ public function test_column_aggregation(): void {
5151
$report = $generator->create_report(['name' => 'Users', 'source' => users::class, 'default' => 0]);
5252

5353
// Report columns, aggregated/sorted by user suspended.
54-
$generator->create_column(['reportid' => $report->get('id'), 'uniqueidentifier' => 'user:firstname']);
54+
$generator->create_column([
55+
'reportid' => $report->get('id'),
56+
'uniqueidentifier' => 'user:firstname',
57+
'sortenabled' => 1,
58+
'sortdirection' => SORT_DESC,
59+
]);
5560
$generator->create_column([
5661
'reportid' => $report->get('id'),
5762
'uniqueidentifier' => 'user:suspended',

reportbuilder/tests/local/aggregation/percent_test.php

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,12 @@ public function test_column_aggregation(): void {
4848
$report = $generator->create_report(['name' => 'Users', 'source' => users::class, 'default' => 0]);
4949

5050
// Report columns, aggregated/sorted by user suspended.
51-
$generator->create_column(['reportid' => $report->get('id'), 'uniqueidentifier' => 'user:firstname']);
51+
$generator->create_column([
52+
'reportid' => $report->get('id'),
53+
'uniqueidentifier' => 'user:firstname',
54+
'sortenabled' => 1,
55+
'sortdirection' => SORT_DESC,
56+
]);
5257
$generator->create_column([
5358
'reportid' => $report->get('id'),
5459
'uniqueidentifier' => 'user:suspended',

reportbuilder/tests/local/aggregation/sum_test.php

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,12 @@ public function test_column_aggregation(): void {
5151
$report = $generator->create_report(['name' => 'Users', 'source' => users::class, 'default' => 0]);
5252

5353
// Report columns, aggregated/sorted by user suspended.
54-
$generator->create_column(['reportid' => $report->get('id'), 'uniqueidentifier' => 'user:firstname']);
54+
$generator->create_column([
55+
'reportid' => $report->get('id'),
56+
'uniqueidentifier' => 'user:firstname',
57+
'sortenabled' => 1,
58+
'sortdirection' => SORT_DESC,
59+
]);
5560
$generator->create_column([
5661
'reportid' => $report->get('id'),
5762
'uniqueidentifier' => 'user:suspended',

0 commit comments

Comments
 (0)