Hyperbolic surface triangulation 2 (new package)

[loic-dubois]

Summary of Changes

This package enables building and handling triangulations of closed orientable hyperbolic surfaces: a basic tool for any future implementation of algorithms operating on such surfaces. Functionalities are offered such as the Delaunay flip algorithm, and the construction of a portion of the lift of the triangulation in the Poincaré disk model of the hyperbolic plane. Triangulations can be generated by triangulating a convex fundamental domain in the Poincaré disk. A method is offered that generates such domains in genus two.

Release Management

• Affected package(s): Hyperbolic_surface_triangulation_2
• Issue(s) solved (if any): -
• Feature/Small Feature (if any): https://cgal.geometryfactory.com/CGAL/Members/wiki/Features/Hyperbolic_Surface_Triangulation
• Link to compiled documentation: link
• License and copyright ownership: GPL INRIA

[afabri]

/build:v0

[github-actions]

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8259/v0/Manual/index.html

[sloriot]

Please check CGAL-6.1-Ic-60 for errors and warnings.

[pougetma]

When compiling examples or tests, it seems a file is missing:
#include <CGAL/license/Triangulation_on_hyperbolic_surface_2.h>
@MaelRL : did you forget to commit it?

[MaelRL]

When compiling examples or tests, it seems a file is missing: #include <CGAL/license/Triangulation_on_hyperbolic_surface_2.h> @MaelRL : did you forget to commit it?

No, the license file is there: https://github.com/CGAL/cgal/pull/8259/files#diff-74d7fd69497c42e2489e25b8ea8b5796a3debbff0098cb3243b636938b720994

[pougetma]

When compiling examples or tests, it seems a file is missing: #include <CGAL/license/Triangulation_on_hyperbolic_surface_2.h> @MaelRL : did you forget to commit it?

No, the license file is there: https://github.com/CGAL/cgal/pull/8259/files#diff-74d7fd69497c42e2489e25b8ea8b5796a3debbff0098cb3243b636938b720994

Ok, thanks, so there must be something wrong with my Cmake config ...

[pougetma]

/build:v1

[github-actions]

There was an error while building the doc:

/home/runner/work/cgal/cgal/Triangulation_on_hyperbolic_surface_2/doc/Triangulation_on_hyperbolic_surface_2/examples.txt:5: warning: included file Triangulation_on_hyperbolic_surface_2/hyperbolic_surface_triangulation.cpp is not found. Check your EXAMPLE_PATH
/home/runner/work/cgal/cgal/Triangulation_on_hyperbolic_surface_2/doc/Triangulation_on_hyperbolic_surface_2/Triangulation_on_hyperbolic_surface_2.txt:133: warning: included file Triangulation_on_hyperbolic_surface_2/hyperbolic_surface_triangulation.cpp is not found. Check your EXAMPLE_PATH

https://github.com/CGAL/cgal/actions/runs/12866464378

[pougetma]

/build:v1

[github-actions]

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8259/v1/Manual/index.html

[albert-github]

@pougetma
I have strong doubts about this file will be available on all systems.

I saw a similar construct on other places as well.

Not related to this PR but I also saw:

Polygon_repair/benchmark/Polygon_repair/write_repaired_polygons.cpp:  std::ifstream ifs("/Users/ken/Downloads/2018418.wkt");
Polygon_repair/benchmark/Polygon_repair/write_repaired_polygons.cpp:  std::ofstream ofs("/Users/ken/Downloads/2.geojson");

though this is in a benchmark that normally is run on a dedicated system / just ran in the past.

[pougetma]

ok, I removed links, but dont understand why my cmake cannot find the Installation/include.license dir ??

[albert-github]

No idea, probably something missing in respect to the cmake include_directories or in ${CGAL_INCLUDE_DIRS} or maybe in the packag.txt.

[MaelRL]

ok, I removed links, but dont understand why my cmake cannot find the Installation/include.license dir ??

I merged master now so everything is up to date on other places, can you please try again?

[pougetma]

Everything seems fine, thanks

[albert-github]

Everywhere else:

cmake_minimum_required(VERSION 3.12...3.29)

is used, so I think this should used here as well (in all CMakeLists.txt of this project)