link: cleanup: sentFile isn't used anymore.

Also, print usb err on failure only.
Display success message when ok.

Author: adriweb

core/link.c

@@ -39,7 +39,9 @@ int EMSCRIPTEN_KEEPALIVE emu_send_variables(const char *const *files, int num, i
         sprintf(argv[i+1], "send%s:%s", locations[location], files[i]);
     }
     int err = usb_init_device(1+num, (const char *const *)argv, progress_handler, progress_context);
-    gui_console_printf("[CEmu] Transfer. usb_init_device ret = %d.\n", err);
+    if (err != 0) {
+        gui_console_printf("[CEmu] USB transfer error code %d.\n", err);
+    }
 
     for(int i=1; i<=num; i++) {
         free(argv[i]);

gui/qt/emuthread.cpp

@@ -241,6 +241,7 @@ bool EmuThread::progressHandler(void *context, int value, int total) {
     EmuThread* emuThread = reinterpret_cast<EmuThread *>(context);
     if (value == 1 && total == 1) {
         emuThread->setThrottle(emuThread->m_backupThrottleForTransfers);
+        gui_console_printf("[CEmu] USB transfer(s) completed succesfully.\n");
     }
     emit emuThread->linkProgress(value, total);
     return false;

gui/qt/emuthread.h

@@ -80,7 +80,6 @@ class EmuThread : public QThread {
     void loaded(emu_state_t state, emu_data_t type);
     void blocked(int req);
     void linkProgress(int value, int total);
-    void sentFile(const QString &file, int ok);
 
 public slots:
     void send(const QStringList &names, int location);

gui/qt/mainwindow.cpp

@@ -392,7 +392,6 @@ MainWindow::MainWindow(CEmuOpts &cliOpts, QWidget *p) : QMainWindow(p), ui(new U
     // sending handler
     connect(sendingHandler, &SendingHandler::send, &emu, &EmuThread::send, Qt::QueuedConnection);
     connect(&emu, &EmuThread::linkProgress, sendingHandler, &SendingHandler::linkProgress, Qt::QueuedConnection);
-    connect(&emu, &EmuThread::sentFile, sendingHandler, &SendingHandler::sentFile, Qt::QueuedConnection);
     connect(sendingHandler, &SendingHandler::loadEquateFile, this, &MainWindow::equatesAddFile);
 
     // memory editors

gui/qt/sendinghandler.cpp

@@ -173,52 +173,6 @@ void SendingHandler::linkProgress(int value, int total) {
     guiSend = false;
 }
 
-void SendingHandler::sentFile(const QString &file, int ok) {
-
-    static int result = LINK_GOOD;
-    result |= ok;
-
-    // Send null to complete sending
-    if (file.isEmpty()) {
-        if (result & LINK_ERR) {
-            QMessageBox::critical(Q_NULLPTR, QObject::tr("Transfer error"), QObject::tr("Transfer Error, see console for information."));
-        }
-        else if (result & LINK_WARN) {
-            QMessageBox::warning(Q_NULLPTR, QObject::tr("Transfer warning"), QObject::tr("Transfer Warning, see console for information."));
-        }
-        result = LINK_GOOD;
-        m_progressBar->setValue(m_progressBar->maximum());
-        guiDelay(100);
-        if (m_progressBar) {
-            m_progressBar->setVisible(false);
-            m_progressBar->setValue(0);
-        }
-        guiSend = false;
-        return;
-    }
-
-    QFileInfo fi(file);
-    QString directory = fi.absolutePath();
-
-    // check for sending of equate file
-    if (m_sendEquates) {
-        if (!m_dirs.contains(directory)) {
-            m_dirs.append(directory);
-            checkDirForEquateFiles(directory);
-        }
-    }
-
-    // don't add temp files (created by bundles)
-    if (directory != m_tempDir.path()) {
-        addFile(file, true);
-    }
-
-    if (m_progressBar) {
-        m_progressBar->setValue(m_progressBar->value() + 1);
-    }
-}
-
-
 void SendingHandler::addFile(const QString &file, bool select) {
     int j, rows = m_table->rowCount();
 

gui/qt/sendinghandler.h

@@ -32,7 +32,6 @@ class SendingHandler : public QObject {
 
 public slots:
     void linkProgress(int amount, int total);
-    void sentFile(const QString &file, int ok);
     void resendPressed();
     void removeRow();