Skip to content

[Ingest] SHA-256 validation for Manifest is case sensitive #2617

@mreyescdl

Description

@mreyescdl

Batch manifest entry must be lowercase for it to validate correctly.
Really surprised to not see this before.

The following manifest entry excerpt will fail validation

sha256 | 30A97B87F5B46B864E6B0A5CCB26C869A0526D2C19EE97B8C7C207F3660FD930

Validation value will be calculated as

SHA-256=30a97b87f5b46b864e6b0a5ccb26c869a0526d2c19ee97b8c7c207f3660fd930

And checked in code with

if (! calculatedChecksum.equals(value)) {
                throw new TException.FIXITY_CHECK_FAILS("[error] submission package checksum mismatch: " + submissionPackage.getName());
            }

Fix should simply be to use

calculatedChecksum.equalsIgnoreCase(value))

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions