Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make in-app touchpoints modal form more accessible #8574

Open
emyl3 opened this issue Mar 4, 2025 · 1 comment
Open

Make in-app touchpoints modal form more accessible #8574

emyl3 opened this issue Mar 4, 2025 · 1 comment
Labels
Accessibility Issues that affect SR's accessibility Critical Critical bugs or a11y issues. Part of [Critical, Serious, Moderate] bug and a11y ranking labels.

Comments

@emyl3
Copy link
Collaborator

emyl3 commented Mar 4, 2025

Area or Component

In-app touchpoints modal form

Quick Summary

The in-app touchpoints modal form can be more accessible through the following:

  1. When tabbing through the touchpoints modal with a screenreader like VoiceOver (macOS), it is not clear that the "X" for the Touchpoints modal form is the close modal button since it is read as "times." (This is probably the exact same issue as the one opened in the static site.)
  2. Add a aria-required="true" attribute for the <textbox> input "What do you think about SimpleReport? Please share feedback on anything you like, or how we can improve."

⚠️ This may be initially straightforward to fix. However, if we ever make changes to the touchpoints form (which we copy and paste the form code directly from touchpoints) we will need to figure out a way to ensure this continues to behave in an accessible manner.

How to Replicate

  • Go to the app
  • Log in
  • Click the "How can we improve SimpleReport?"
  • Try using a screenreader to tab through the form to replicate number 1 above.

Accessibility Violation

aria-name-missing-incorrect

aria-required-missing

Action Requested

  • Fix the above accessibility issues
  • Ensure there is an easy(?-not sure if possible) or at least structured way to maintain these changes if we update the Touchpoints modal in the future

Screenshots (optional)

Screenshot 2025-03-04 at 11.45.48.png

Source Code (optional)

Original Deque Issue

@emyl3 emyl3 added the Accessibility Issues that affect SR's accessibility label Mar 4, 2025
@emyl3
Copy link
Collaborator Author

emyl3 commented Mar 4, 2025

⚠️ Please address this issue in conjunction with #8573

@DanielSass DanielSass added this to the 508 resolution milestone Mar 7, 2025
@DanielSass DanielSass added the Critical Critical bugs or a11y issues. Part of [Critical, Serious, Moderate] bug and a11y ranking labels. label Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Issues that affect SR's accessibility Critical Critical bugs or a11y issues. Part of [Critical, Serious, Moderate] bug and a11y ranking labels.
Projects
None yet
Development

No branches or pull requests

2 participants