Skip to content

Commit a434a66

Browse files
committed
remove unused parameter
1 parent 68adeaa commit a434a66

File tree

2 files changed

+9
-10
lines changed

2 files changed

+9
-10
lines changed

Diff for: query-connector/src/app/backend/usergroup-management.ts

+8-9
Original file line numberDiff line numberDiff line change
@@ -61,24 +61,23 @@ export async function createUserGroup(
6161
* Updates the name of an existing user group.
6262
* @param id - The unique identifier of the user group to update.
6363
* @param newName - The new name to assign to the user group.
64-
* @param userIds - The new name to assign to the user group.
65-
// * @param queryIds - The new name to assign to the user group.
6664
* @returns The updated user group or an error if the update fails.
6765
*/
6866
export async function updateUserGroup(
6967
id: string,
7068
newName: string,
71-
userIds?: string[],
7269
): Promise<UserGroup | string> {
7370
if (!(await superAdminAccessCheck())) {
7471
throw new Error("Unauthorized");
7572
}
76-
console.log(id, newName);
73+
7774
try {
7875
// Check if the new name already exists
7976
const existingGroups = await getAllUserGroups();
8077
const groupExists =
81-
existingGroups.items?.some((group) => group.name === newName) ?? false;
78+
existingGroups.items?.some((group) => {
79+
return group.name === newName;
80+
}) ?? false;
8281

8382
if (groupExists) {
8483
console.warn(`Group with name '${newName}' already exists.`);
@@ -91,11 +90,11 @@ export async function updateUserGroup(
9190
WHERE id = $2
9291
RETURNING id, name;
9392
`;
94-
const escapedValues =
95-
userIds && userIds.map((_, i) => `$${i + 1}`).join() + ")";
96-
const queryString = updateUserGroupMembersQuery + escapedValues;
9793

98-
const result = await dbClient.query(queryString, [newName, id, userIds]);
94+
const result = await dbClient.query(updateUserGroupMembersQuery, [
95+
newName,
96+
id,
97+
]);
9998

10099
if (result.rows.length === 0) {
101100
throw new Error(`User group with ID '${id}' not found.`);

Diff for: query-connector/src/app/tests/integration/usergroup-management.test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ describe("User Group and Query Membership Tests", () => {
7676
await dbClient.query("DELETE FROM usergroup WHERE id = $1;", [
7777
TEST_GROUP_ID,
7878
]);
79-
await dbClient.query("DELETE FROM users WHERE id IN ($1, $2);", [
79+
await dbClient.query("DELETE FROM users WHERE id IN ($1, $2, $3);", [
8080
TEST_USER_1_ID,
8181
TEST_USER_2_ID,
8282
TEST_USER_3_ID,

0 commit comments

Comments
 (0)