You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I did not pay attention to tests. We can change and cleanup as needed and I will have the build process run the tests
Are you using pytest? If not that would be my recommendation
The vtools tests I have retained or recently committed are representative of the style. The prior vtools tests spanned 2-3 prior recommended frameworks. Some of theme were kind of nice, but I was far more willing to spend 30min coaching ChatGPT through the process to modernize them than to re-write by hand.
I'm more willing to vouch that we are ready for the vtools tests. I don't know what dms_datastore tests look. However, I'm willing to fix them. A lot of the functionality is CLI, and one nice thing about click is click.testing. On the other hand, the downloading scripts are hard to test in a way that includes actual downloads. I don't know if that is mockable and even if it is I'm not sure it is worthwhile.
________________________________
From: Nicky Sandhu ***@***.***>
Sent: Sunday, March 2, 2025 2:44 PM
To: CADWRDeltaModeling/dms_datastore ***@***.***>
Cc: Ateljevich, ***@***.*** (he/him) ***@***.***>; Author ***@***.***>
Subject: Re: [CADWRDeltaModeling/dms_datastore] .gitignore excludes all csv and there are two /example directories at different scope (Issue #61)
[dwr-psandhu]dwr-psandhu left a comment (CADWRDeltaModeling/dms_datastore#61)<#61 (comment)>
I did not pay attention to tests. We can change and cleanup as needed and I will have the build process run the tests
Are you using pytest? If not that would be my recommendation
—
Reply to this email directly, view it on GitHub<#61 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AG2AJCYKNHNVDXQCKFQN6QD2SOCT5AVCNFSM6AAAAABYFS2MKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOJSHE2DONBQGI>.
You are receiving this because you authored the thread.
Not quite sure how any tests can be correctly orchestrated under these conditions. @dwr-psandhu what do you prefer?
The text was updated successfully, but these errors were encountered: