Muphys: Remove copies of arrays in false branches#1106
Open
iomaganaris wants to merge 205 commits intomainfrom
Open
Muphys: Remove copies of arrays in false branches#1106iomaganaris wants to merge 205 commits intomainfrom
iomaganaris wants to merge 205 commits intomainfrom
Conversation
…merge' into muphys_bug_fix
Clean up the graupel_only driver, and create an integration test to run through pytest. Co-authored-by: Will Sawyer <wsawyer@cscs.ch>
Co-authored-by: Will Sawyer <vectorflux@gmail.com> Co-authored-by: Will Sawyer <wsawyer@cscs.ch>
Contributor
|
cscs-ci run default |
Contributor
|
cscs-ci run default |
Contributor
|
cscs-ci run dace |
Contributor
|
cscs-ci run distributed |
Contributor
|
It works on GPU, but validation fails on CPU. I see errors in CPU validation also in muphys-ppp. It could be that we have missed propagating some strides, I will have a look. |
Contributor
|
cscs-ci run dace |
Contributor
|
cscs-ci run dace |
Contributor
|
cscs-ci run dace |
This reverts commit cca30ab.
Contributor
|
cscs-ci run dace |
|
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests To run benchmarks you can use:
To run tests and benchmarks with the DaCe backend you can use:
To run test levels ignored by the default test suite (mostly simple datatest for static fields computations) you can use:
For more detailed information please look at CI in the EXCLAIM universe. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
graupelSDFG looks like the following:In both maps there are outputs whose values are determined based on if-statements that check if a mask or multiple masks are activated. In case they are not the values of the maps are updated with the inputs without any change.
Since we know that the inputs and outputs are the same pointers we can improve this patter by removing the copies in the false branches of the if-statements and replacing the intermediate temporary
AccessNodes with the globalAccessNodes that are used as outputs of the program.To be more specific, the
AccessNodes where this is applied are:q_in_2->q_out_2q_in_3->q_out_3q_in_4->q_out_4q_in_5->q_out_5te->t_outThis is the updated SDFG: