trying to construct config from namelist

Author: OngChia

model/testing/src/icon4py/model/testing/datatest_utils.py

@@ -10,6 +10,9 @@
 
 import pathlib
 import urllib.parse
+import ast
+import re
+
 
 import gt4py.next.typing as gtx_typing
 
@@ -72,3 +75,85 @@ def create_icon_serial_data_provider(
         mpi_rank=rank,
         do_print=True,
     )
+
+
+def read_namelist(path: pathlib.Path) -> dict:
+    """ICON NAMELIST_ICON_output_atm reader.
+    Returns a dictionary of dictionaries, where the keys are the namelist names
+    and the values are dictionaries of key-value pairs from the namelist.
+
+    Use as:
+    namelists = read_namelist("/path/to/NAMELIST_ICON_output_atm")
+    print(namelists["NWP_TUNING_NML"]["TUNE_ZCEFF_MIN"])
+    """
+    with path.open() as f:
+        txt = f.read()
+    namelist_set = re.findall(r"&(\w+)(.*?)\/", txt, re.S)
+    full_namelist = {}
+    for namelist_name, namelist_content in namelist_set:
+        full_namelist[namelist_name] = _parse_namelist_content(namelist_content)
+    return full_namelist
+
+
+def _parse_namelist_content(namelist_content):
+    """
+    Parse the contents of a single namelist group to a Python dictionary.
+    """
+    result = {}
+    current_variable = None
+
+    # Remove comments
+    namelist_content = re.sub(r"!.*", "", namelist_content)
+
+    # Split into lines
+    lines = namelist_content.splitlines()
+
+    for line in lines:
+        line = line.strip()
+        # skip any non-meaningful empty line
+        if not line:
+            continue
+
+        # Remove trailing comma
+        if line.endswith(","):
+            line = line[:-1]
+
+        if "=" in line:
+            # New variable-value pair
+            variable, value = line.split("=", 1)
+            current_variable = variable.strip()
+            result[current_variable] = _parse_value(value)
+        # TODO(Chia Rui): check if continuation lines is irrelevant in our tests
+        # else:
+        #     # Continuation line (array or multi-line string)
+        #     if current_variable is not None:
+        #         val = _parse_value(line)
+        #         # convert to a list if we have multiple values for the same variable
+        #         if not isinstance(result[current_variable], list):
+        #             result[current_variable] = [result[current_variable]]
+        #         result[current_variable].append(val)
+
+    return result
+
+
+def _parse_value(value):
+    """
+    Convert Fortran-style values to Python types.
+    """
+    value = value.strip()
+
+    # Fortran logical
+    if value in ("T", ".T."):
+        return True
+    if value in ("F", ".F."):
+        return False
+
+    # Quoted string
+    if value.startswith("'") and value.endswith("'"):
+        return value[1:-1].rstrip()
+
+    # Try numeric conversion
+    try:
+        return ast.literal_eval(value)
+    except Exception:
+        return value

model/testing/src/icon4py/model/testing/definitions.py

@@ -28,6 +28,7 @@
 SERIALIZED_DATA_DIR: Final = "ser_icondata"
 SERIALIZED_DATA_SUBDIR: Final = "ser_data"
 GRID_DATA_DIR: Final = "grids"
+NAMELIST_FILENAME: Final = "NAMELIST_ICON_output_atm"
 
 
 def serialized_data_path() -> pathlib.Path:
@@ -201,6 +202,7 @@ def construct_diffusion_config(
 ) -> diffusion.DiffusionConfig:
     from icon4py.model.atmosphere.diffusion import diffusion
 
+
     if experiment == Experiments.MCH_CH_R04B09:
         return diffusion.DiffusionConfig(
             diffusion_type=diffusion.DiffusionType.SMAGORINSKY_4TH_ORDER,

model/testing/src/icon4py/model/testing/fixtures/datatest.py

@@ -16,7 +16,7 @@
 import icon4py.model.common.decomposition.definitions as decomposition
 from icon4py.model.common import model_backends, model_options
 from icon4py.model.common.constants import RayleighType
-from icon4py.model.common.grid import base as base_grid
+from icon4py.model.common.grid import base as base_grid, vertical as v_grid
 from icon4py.model.testing import data_handling, datatest_utils as dt_utils, definitions
 
 
@@ -154,6 +154,42 @@ def data_provider(
     return dt_utils.create_icon_serial_data_provider(data_path, processor_props.rank, backend)
 
 
+@pytest.fixture
+def icon_namelist(
+    download_ser_data: None,  # downloads data as side-effect
+    experiment: definitions.Experiment,
+    processor_props: decomposition.ProcessProperties,
+) -> dict:
+    experiment_dir = dt_utils.get_ranked_experiment_name_with_version(
+        experiment,
+        processor_props.comm_size,
+    )
+    namelist_path = definitions.serialized_data_path().joinpath(
+        experiment_dir, definitions.NAMELIST_FILENAME
+    )
+    return dt_utils.read_namelist(namelist_path)
+
+
+@pytest.fixture
+def vertical_grid_config(
+    icon_namelist: dict,
+) -> v_grid.VerticalGridConfig:
+    return v_grid.VerticalGridConfig(
+        # TODO (Chia Rui): where should we put the config construction? And remove this hardcoded style in next commits
+        num_levels=icon_namelist["RUN_NML"]["NUM_LEV"],
+        maximal_layer_thickness=icon_namelist["SLEVE_NML"]["MAX_LAY_THCKN"],
+        top_height_limit_for_maximal_layer_thickness=icon_namelist["SLEVE_NML"]["HTOP_THCKNLIMIT"],
+        lowest_layer_thickness=icon_namelist["SLEVE_NML"]["MIN_LAY_THCKN"],
+        model_top_height=icon_namelist["SLEVE_NML"]["TOP_HEIGHT"],
+        flat_height=icon_namelist["SLEVE_NML"]["FLAT_HEIGHT"],
+        stretch_factor=icon_namelist["SLEVE_NML"]["STRETCH_FAC"],
+        rayleigh_damping_height=icon_namelist["NONHYDROSTATIC_NML"]["DAMP_HEIGHT"],
+        htop_moist_proc=icon_namelist["NONHYDROSTATIC_NML"]["HTOP_MOIST_PROC"],
+        SLEVE_decay_scale_1=icon_namelist["SLEVE_NML"]["DECAY_SCALE_1"],
+        SLEVE_decay_scale_2=icon_namelist["SLEVE_NML"]["DECAY_SCALE_2"],
+        SLEVE_decay_exponent=icon_namelist["SLEVE_NML"]["DECAY_EXP"],
+    )
+
 @pytest.fixture
 def grid_savepoint(
     data_provider: serialbox.IconSerialDataProvider, experiment: definitions.Experiment