Skip to content

Commit f34dc9e

Browse files
committed
DeployRunner: Fix regression caused by role selection
This reverts commit 31c9cdf. The role selection does not work, because: - The label is actually called `roles` - The `roles` label is an array, so `=` comparison with a role string does not work - Deployer selector does not support a comparison operator to check if an array contains a value
1 parent 4aaae03 commit f34dc9e

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

src/DeployRunner.php

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -150,22 +150,13 @@ private function initializeConfigurableTask(ConfigurableTaskInterface $task, Con
150150
if ($task->supports($taskConfig)) {
151151
$task = $task->configureWithTaskConfig($taskConfig);
152152

153-
if ($task && $taskConfig instanceof ServerRoleConfigurableInterface) {
154-
$this->configureTaskOnServerRoles($task, $taskConfig);
155-
}
156-
157153
if ($task && $taskConfig instanceof StageConfigurableInterface) {
158154
$this->configureTaskOnStage($task, $taskConfig);
159155
}
160156
}
161157
}
162158
}
163159

164-
private function configureTaskOnServerRoles(Task $task, ServerRoleConfigurableInterface $taskConfiguration)
165-
{
166-
$task->select('role=' . implode(',role=', $taskConfiguration->getServerRoles()));
167-
}
168-
169160
private function configureTaskOnStage(Task $task, StageConfigurableInterface $taskConfiguration)
170161
{
171162
if (!$taskConfiguration->getStage()) {

0 commit comments

Comments
 (0)