Skip to content

Commit b3387fc

Browse files
committed
DeployRunner: Fix task variable being overridden by other var type
$task is of type ConfigurableTaskInterface, while $deployerTask is of type Task (from Deployer). Next taskConfig iteration would run `supports` on Deployer Task type, which obviously does not exist.
1 parent f34dc9e commit b3387fc

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/DeployRunner.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -148,10 +148,10 @@ private function initializeConfigurableTask(ConfigurableTaskInterface $task, Con
148148

149149
foreach ($configurations as $taskConfig) {
150150
if ($task->supports($taskConfig)) {
151-
$task = $task->configureWithTaskConfig($taskConfig);
151+
$deployerTask = $task->configureWithTaskConfig($taskConfig);
152152

153-
if ($task && $taskConfig instanceof StageConfigurableInterface) {
154-
$this->configureTaskOnStage($task, $taskConfig);
153+
if ($deployerTask && $taskConfig instanceof StageConfigurableInterface) {
154+
$this->configureTaskOnStage($deployerTask, $taskConfig);
155155
}
156156
}
157157
}

0 commit comments

Comments
 (0)