Skip to content

Commit 862e5bf

Browse files
authored
Channel org binding, paired-computer approvals and sign-in return fixes (#9548)
* Run channel messages only for members of the channel's organization * Ask before remote coding runs, host-bound jobs and non-GET web requests * Keep production sign-in returns on the app's own origins * Check the embed session for MCP sandbox frame hosts * Cover two-factor and integration settings in the same-origin check; require a verified email for auto-join domains * Narrow template inputs: distiller tools, html plans, render fetches, paste parsing, booking titles, vault org lookup * Spawn skills installs without a shell and check source refs * Ask before updating host-bound jobs and automations; retry channel messages when the org lookup fails * Look up an automation update's target the same way the update does * Check channel enable, disable and setup requests for the same-origin marker * Record legacy channel orgs once, share the execution-target check, drop html from plan create * Bind a deployment admin's channel takeover to the admin's own scope
1 parent 10ed5b2 commit 862e5bf

54 files changed

Lines changed: 1716 additions & 147 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@agent-native/core": patch
3+
---
4+
5+
Inbound messages on a channel set up by an organization run only for members of that organization. Deployment admins can take over a channel's setup from any organization.

‎.changeset/host-job-approval.md‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@agent-native/core": patch
3+
---
4+
5+
Scheduling a job on a paired computer, editing job files, and sending web requests other than GET or HEAD from chat ask for approval first.
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@agent-native/core": patch
3+
---
4+
5+
Apps opened from an MCP app sandbox confirm their embed session before they accept the host frame.

‎.changeset/remote-run-approval.md‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@agent-native/dispatch": patch
3+
---
4+
5+
Starting or continuing a coding run on a paired computer asks for approval each time.
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
"@agent-native/core": patch
3+
"@agent-native/toolkit": patch
4+
---
5+
6+
Two-factor, integration settings, and channel enable, disable and setup requests need the same-origin marker, like other cookie-authenticated writes. Setting an organization's auto-join domain needs a verified email.
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@agent-native/core": patch
3+
---
4+
5+
Production sign-in returns only to the app's own origins.

‎.changeset/skills-add-ref-check.md‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@agent-native/skills": patch
3+
---
4+
5+
`skills add` now checks the git ref of a GitHub source before cloning and stops with an "Invalid source ref" error if it contains anything other than letters, digits, `.`, `_`, `/`, and `-`, or starts with `-`. Package-manager commands on Windows now go through a quoted command line instead of an unquoted shell.
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@agent-native/core": patch
3+
---
4+
5+
`agent-native skills` now starts `npx` through the same quoted Windows command-line handling as the other CLI commands, and the unused delegated-call metadata object in `call-agent` is removed.

‎packages/core/package.json‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -441,6 +441,10 @@
441441
"./client/transcription/use-live-transcription": "./dist/client/transcription/use-live-transcription.js",
442442
"./transcription/builder": "./dist/transcription/builder-transcription.js",
443443
"./adapters/cli": "./dist/adapters/cli/index.js",
444+
"./cli/process": {
445+
"types": "./dist/cli/process.d.ts",
446+
"default": "./dist/cli/process.js"
447+
},
444448
"./cli/telemetry": {
445449
"types": "./dist/cli/telemetry.d.ts",
446450
"default": "./dist/cli/telemetry.js"

‎packages/core/src/cli/skills.ts‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ import {
4545
installScreenMemoryForClient,
4646
resolveScreenMemoryStoreDir,
4747
} from "./mcp.js";
48+
import { shimSpawnTarget } from "./process.js";
4849
import {
4950
createAgentSymlink,
5051
prepareAgentSymlink,
@@ -3523,9 +3524,10 @@ async function runCommand(
35233524
const silent = options.stdio === "silent";
35243525
const stdoutChunks: Buffer[] = [];
35253526
const stderrChunks: Buffer[] = [];
3526-
const child = spawn(cmd, args, {
3527+
const [spawnCmd, spawnArgs, shell] = shimSpawnTarget(cmd, args);
3528+
const child = spawn(spawnCmd, spawnArgs, {
35273529
stdio: pipeToStderr || silent ? ["inherit", "pipe", "pipe"] : "inherit",
3528-
shell: process.platform === "win32",
3530+
shell,
35293531
env: process.env,
35303532
});
35313533
if (pipeToStderr) {

0 commit comments

Comments
 (0)