Skip to content

Commit c407e09

Browse files
committed
Refactor test for nested groups to improve readability and maintainability
1 parent 9974585 commit c407e09

File tree

1 file changed

+6
-7
lines changed

1 file changed

+6
-7
lines changed

tests/test_groups.py

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -128,12 +128,11 @@ def test_nested_groups_with_multiple_elements_with_quantifiers():
128128
possibilities = ['']
129129
group = ['e', 'f', 'g', 'ee', 'ef', 'eg', 'fe', 'ff', 'fg', 'ge', 'gf', 'gg', 'eee', 'eef', 'eeg', 'efe', 'eff', 'efg', 'ege', 'egf', 'egg',
130130
'fee', 'fef', 'feg', 'ffe', 'fff', 'ffg', 'fge', 'fgf', 'fgg', 'gee', 'gef', 'geg', 'gfe', 'gff', 'gfg', 'gge', 'ggf', 'ggg']
131-
one_group = [f'a{g}' for g in group]
132-
two_groups = [f'a{g1}a{g2}' for g1 in group for g2 in group]
133-
three_groups = [f'a{g1}a{g2}a{
134-
g3}' for g1 in group for g2 in group for g3 in group]
135-
possibilities.extend(one_group)
136-
possibilities.extend(two_groups)
137-
possibilities.extend(three_groups)
131+
one = [f'a{g}' for g in group]
132+
two = [f'{g1}{g2}' for g1 in one for g2 in one]
133+
three = [f'{g1}{g2}{g3}' for g1 in one for g2 in one for g3 in one]
134+
possibilities.extend(one)
135+
possibilities.extend(two)
136+
possibilities.extend(three)
138137

139138
f_finite(regexEnumerator, set(possibilities))

0 commit comments

Comments
 (0)