removed PHP 5 dependencies and added php7.0-mbstring dependancy#40
Open
dotps1 wants to merge 4 commits intoBrewPi:masterfrom
Open
removed PHP 5 dependencies and added php7.0-mbstring dependancy#40dotps1 wants to merge 4 commits intoBrewPi:masterfrom
dotps1 wants to merge 4 commits intoBrewPi:masterfrom
Conversation
Removed the php5 dependencies that was suggested in BrewPi#39. The script now runs fine, however, the website is still unavailable after it completes.
There was a missing dependency, `php7.0-mbstring` that was causing the `/index.php` to not display, and throwing an error in the `/var/log/apache2/error.log`:
```
PHP Fatal error: Uncaught Error: Call to undefined function mb_convert_encoding() in /var/www/html/index.php:53\nStack trace:\n#0 /var/www/html/index.php(24): prepareJSON('{"beerName": "S...')\n#1 {main}\n thrown in /var/www/html/index.php on line 53
```
Member
|
Thanks for the PR :) Regarding configobj, it's already installed a few lines down using pip, why is the apt install needed? |
Author
|
here is the output from running the brewpi.py this is a fresh install, so when I run the python script, it appears to be missing both python-configobj and psutil from pip. |
|
Has this been merged yet? I'm still getting exactly the same error as in #39 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the php 5.0 dependencies from the install.sh script. I also added the
php7.0-mbstringdependency that was being called by theindex.php. The missing dependency would cause a500error and throw and error in the/var/log/apache2/error.logThis can all be found in issue #39.