Updated PHPStan to 0.12 and fixed new errors.

Author: BluePsyduck

.travis.yml

@@ -7,8 +7,6 @@ matrix:
     - php: 7.2
     - php: 7.3
     - php: 7.4
-  allow_failures:
-    - php: 7.4
 
 cache:
   directories:

composer.json

@@ -17,12 +17,12 @@
     "symfony/process": "^3.0 || ^4.0 || ^5.0"
   },
   "require-dev": {
-    "bluepsyduck/common": "^1.0",
-    "phpstan/phpstan": "^0.10",
-    "phpstan/phpstan-phpunit": "^0.10",
-    "phpstan/phpstan-strict-rules": "^0.10",
+    "bluepsyduck/test-helper": "^1.0",
+    "phpstan/phpstan": "^0.12",
+    "phpstan/phpstan-phpunit": "^0.12",
+    "phpstan/phpstan-strict-rules": "^0.12",
     "phpunit/phpunit": "^7.3",
-    "rregeer/phpunit-coverage-check": "^0.1",
+    "rregeer/phpunit-coverage-check": "^0.3",
     "squizlabs/php_codesniffer": "^3.3"
   },
   "autoload": {

phpcs.xml

@@ -1,6 +1,7 @@
 <?xml version="1.0"?>
 <ruleset>
     <file>./src</file>
+    <file>./test/src</file>
 
-    <rule ref="PSR2" />
-</ruleset>
+    <rule ref="PSR12" />
+</ruleset>

src/ProcessManager.php

@@ -35,13 +35,13 @@ class ProcessManager implements ProcessManagerInterface
 
     /**
      * The processes currently waiting to be executed.
-     * @var array
+     * @var array<mixed>
      */
     protected $pendingProcessData = [];
 
     /**
      * The processes currently running.
-     * @var array|Process[]
+     * @var array<Process<string>>
      */
     protected $runningProcesses = [];
 
@@ -166,7 +166,7 @@ public function setProcessCheckCallback(?callable $processCheckCallback)
     /**
      * Invokes the callback if it is an callable.
      * @param callable|null $callback
-     * @param Process $process
+     * @param Process<string> $process
      */
     protected function invokeCallback(?callable $callback, Process $process): void
     {
@@ -177,9 +177,9 @@ protected function invokeCallback(?callable $callback, Process $process): void
 
     /**
      * Adds a process to the manager.
-     * @param Process $process
+     * @param Process<string> $process
      * @param callable|null $callback
-     * @param array $env
+     * @param array<mixed> $env
      * @return $this
      */
     public function addProcess(Process $process, callable $callback = null, array $env = [])
@@ -236,7 +236,7 @@ protected function checkRunningProcesses(): void
     /**
      * Checks the process whether it has finished.
      * @param int|null $pid
-     * @param Process $process
+     * @param Process<string> $process
      */
     protected function checkRunningProcess(?int $pid, Process $process): void
     {
@@ -254,7 +254,7 @@ protected function checkRunningProcess(?int $pid, Process $process): void
 
     /**
      * Checks whether the process already timed out.
-     * @param Process $process
+     * @param Process<string> $process
      */
     protected function checkProcessTimeout(Process $process): void
     {

src/ProcessManagerInterface.php

@@ -16,9 +16,9 @@ interface ProcessManagerInterface
 {
     /**
      * Adds a process to the manager.
-     * @param Process $process
+     * @param Process<string> $process
      * @param callable|null $callback
-     * @param array $env
+     * @param array<mixed> $env
      * @return $this
      */
     public function addProcess(Process $process, callable $callback = null, array $env = []);

test/src/ProcessManagerTest.php

@@ -4,7 +4,7 @@
 
 namespace BluePsyduckTest\SymfonyProcessManager;
 
-use BluePsyduck\Common\Test\ReflectionTrait;
+use BluePsyduck\TestHelper\ReflectionTrait;
 use BluePsyduck\SymfonyProcessManager\ProcessManager;
 use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
@@ -156,7 +156,7 @@ public function testSetProcessCheckCallback(): void
 
     /**
      * Provides the data for the invokeCallback test.
-     * @return array
+     * @return array<mixed>
      */
     public function provideInvokeCallback(): array
     {
@@ -231,7 +231,7 @@ public function testAddProcess(): void
 
     /**
      * Provides the data for the executeNextPendingProcess test.
-     * @return array
+     * @return array<mixed>
      */
     public function provideExecuteNextPendingProcess(): array
     {
@@ -312,7 +312,7 @@ public function testExecuteNextPendingProcess(?int $pid, bool $expectRunningProc
 
     /**
      * Provides the data for the canExecuteNextPendingRequest test.
-     * @return array
+     * @return array<mixed>
      */
     public function provideCanExecuteNextPendingRequest(): array
     {
@@ -325,9 +325,9 @@ public function provideCanExecuteNextPendingRequest(): array
 
     /**
      * Tests the canExecuteNextPendingRequest method.
-     * @param array $runningProcesses
+     * @param array<Process<string>> $runningProcesses
      * @param int $numberOfParallelProcesses
-     * @param array $pendingProcessData
+     * @param array<mixed> $pendingProcessData
      * @param bool $expectedResult
      * @throws ReflectionException
      * @covers ::canExecuteNextPendingRequest
@@ -377,7 +377,7 @@ public function testCheckRunningProcesses(): void
 
     /**
      * Provides the data for the checkRunningProcess test.
-     * @return array
+     * @return array<mixed>
      */
     public function provideCheckRunningProcess(): array
     {
@@ -446,7 +446,7 @@ public function testCheckRunningProcess(
 
     /**
      * Provides the data for the checkProcessTimeout test.
-     * @return array
+     * @return array<mixed>
      */
     public function provideCheckProcessTimeout(): array
     {
@@ -542,7 +542,7 @@ public function testSleep(): void
 
     /**
      * Provides the data for the hasUnfinishedProcesses test.
-     * @return array
+     * @return array<mixed>
      */
     public function provideHasUnfinishedProcesses(): array
     {
@@ -555,8 +555,8 @@ public function provideHasUnfinishedProcesses(): array
 
     /**
      * Tests the hasUnfinishedProcesses method.
-     * @param array $pendingProcessData
-     * @param array $runningProcesses
+     * @param array<mixed> $pendingProcessData
+     * @param array<Process<string>> $runningProcesses
      * @param bool $expectedResult
      * @throws ReflectionException
      * @covers ::hasUnfinishedProcesses