makefile improvements, php memroy limits in passthru

Author: Doug Hatcher

Makefile

@@ -16,8 +16,9 @@ help:
 build: ## creates binary
 	go build ${LDFLAGS} .
 install: build ## compiles and installs into system
-	sudo cp magento-cli /usr/local/bin/magento
-	sudo chmod +x /usr/local/bin/magento
+	rm ~/.magento-cloud/bin/magento
+	cp ./magento-cli ~/.magento-cloud/bin/magento
+	sudo chmod +x ~/.magento-cloud/bin/magento
 run: ## run the command through go, accepts args i.e. `make run -- build -h`
 	go run ${LDFLAGS} ./main.go $(RUN_ARGS)
 test: build

tasks/_global.yaml

@@ -28,10 +28,10 @@ definitions:
       description: routes used for local development server
       default: $(pwd)/pub/ $(pwd)/phpserver/router.php
 
-    - name: php-bin-cmd
+    - name: php-cmd
       type: string
       description: default command to use to trigger local php server
-      default: php -d memory_limit=-1 -d max_input_time=3600 -d max_input_vars=10000 -S
+      default: php -d memory_limit=-1 -d max_input_time=3600 -d max_input_vars=10000
 
     - name: php-bin-path
       type: string

tasks/passthru.yaml

@@ -1,5 +1,6 @@
 #!/usr/bin/env variant
 interactive: true
+parameters: *global
 script: |
   CMD=$(echo {{ index .args }} |  sed -r 's/(\[|\])//g')
-  $MAGECLI_PHP_CMD bin/magento $CMD
+  echo {{ get "php-bin-cmd" }} bin/magento $CMD

tasks/serve.yaml

@@ -3,6 +3,6 @@ tasks:
   serve:
     parameters: *global 
     script: |
-      COMMAND="{{ get "php-bin-cmd" }} {{ get "host" }}:{{ get "port" }} -t {{ get "routes" }}"
+      COMMAND="{{ get "php-bin-cmd" }} -S {{ get "host" }}:{{ get "port" }} -t {{ get "routes" }}"
       echo $COMMAND
       $COMMAND