-
Notifications
You must be signed in to change notification settings - Fork 43
refactor(plugins/anthropic): migrate plugin to v2 API #347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@CorieW build is failing on anthropic example, probably needs a bit of investigation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple of comments so far
|
I think the list method might need to call the anthropic SDK list models method/ API endpoint, and return "potential" models etc. We should double check this. This seems to be what google-genai is doing. |
cad60e9 to
8ea4446
Compare
8ea4446 to
df8c45a
Compare
| configSchema: ref.configSchema, | ||
| }) : undefined; | ||
| }) | ||
| // Filter out undefined values |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is comment necessary? would rather have a comment explaining why this logic works/is necessary
Resolves #349
What this does
Testing
'pluginName/modelName'), checked using a flow works consistent with pre-migration..list