Skip to content

Conversation

@CorieW
Copy link
Contributor

@CorieW CorieW commented Sep 22, 2025

Resolves #349

What this does

  • Upgrades Genkit to the latest version
  • Migrates the plugin API to v2 (doc)

Testing

  • Checked that the models load with the same names/prefixes on the UI.
image
  • Checked that at least one model works consistent with pre-migration on the UI.
image
  • Using a model object, checked using a flow works consistent with pre-migration.
image
  • Using a model string ('pluginName/modelName'), checked using a flow works consistent with pre-migration.
image
  • Tested error response from model.
image
  • Tested resolve.
image
  • Tested model streaming in flow.
image
  • Tested model media input.
image
  • Tested model tool calling.
image
  • Tested .list
image

@CorieW CorieW marked this pull request as draft September 22, 2025 21:53
@xavidop xavidop marked this pull request as ready for review September 23, 2025 15:58
@cabljac
Copy link
Contributor

cabljac commented Sep 29, 2025

@CorieW build is failing on anthropic example, probably needs a bit of investigation

Copy link
Contributor

@cabljac cabljac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of comments so far

@cabljac
Copy link
Contributor

cabljac commented Oct 17, 2025

I think the list method might need to call the anthropic SDK list models method/ API endpoint, and return "potential" models etc. We should double check this. This seems to be what google-genai is doing.

@CorieW CorieW force-pushed the migrate-anthropic-v2 branch from cad60e9 to 8ea4446 Compare October 20, 2025 16:43
@CorieW CorieW force-pushed the migrate-anthropic-v2 branch from 8ea4446 to df8c45a Compare October 20, 2025 16:44
@CorieW CorieW requested a review from cabljac October 22, 2025 22:38
configSchema: ref.configSchema,
}) : undefined;
})
// Filter out undefined values
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is comment necessary? would rather have a comment explaining why this logic works/is necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor: migrate anthropic plugin to V2 Plugin API

2 participants