Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scanlines mode options or glsl shader support? #425

Open
RetroD opened this issue Feb 6, 2019 · 11 comments
Open

Scanlines mode options or glsl shader support? #425

RetroD opened this issue Feb 6, 2019 · 11 comments
Assignees
Milestone

Comments

@RetroD
Copy link

RetroD commented Feb 6, 2019

Would it be possible at all to add some options for scanlines such as opacity (something like 25, 50, 75, 100%) and a filter to soften the image a bit? Even better, can glsl shader support be added so that we can use the same shader library from libretro? (all to be saved globally in the amiberry.conf of course :P )

Don't know about the feasibility for such requests, and I understand is not a priority by any means, but I thought I'd throw it out here to see what you guys think :)

Running 2.24 on retropie stretch on rpi3

@midwan midwan self-assigned this Feb 6, 2019
@midwan
Copy link
Collaborator

midwan commented Feb 6, 2019

Yes, I was planning to look into this at some point in the future... :)

@mrfomt
Copy link

mrfomt commented May 4, 2019

This would be great if you could add to Amiberry!

@sphaero
Copy link

sphaero commented Dec 21, 2019

Any pointers where to start? I know uae4arm-rpi has some shader support. I'm not even sure yet if Amiberry is even using OpenGLES. 🤔

@midwan
Copy link
Collaborator

midwan commented Feb 21, 2020

@sphaero Amiberry uses SDL2 but does not explicitly request a GL context to open the window.
To use GL shaders, we'll have to change that obviously.

I didn't have time to experiment with this yet, but if you want to help with it, pull requests are always welcome! :)

@sphaero
Copy link

sphaero commented Dec 14, 2024

FWIW, I've just build amiberry from source with USE_OPENGL=ON. I had to change CMakeLists.txt

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 74a8d5ab..04468ae2 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -38,7 +38,7 @@ set(PROJECT_COMPANY_NAMESPACE "com.blitterstudio")  # Reverse domain name notati
 include(GNUInstallDirs)
 
 include(cmake/StandardProjectSettings.cmake)
-include(cmake/Dependencies.cmake)
 include(cmake/SourceFiles.cmake)
+include(cmake/Dependencies.cmake)

It builds fine but when I run it I get a few first frames from kickstart booting but it then remains black. When I kill it spits Vertex Shader Error: Vertex Shader Error: Vertex Shader Error:

Still quite experimental I guess?

@midwan
Copy link
Collaborator

midwan commented Dec 14, 2024

Yeah, sorry - this is not implemented completely yet. There are some bugs which I haven't had a chance to fix there.

@sphaero
Copy link

sphaero commented Dec 15, 2024

No worries, I can only salute your work. It seems I get nostalgic every time around christmas and start firing up amiga stuff. It's just too little time to acquaint myself with the source to do something 😞

@filevans
Copy link

Yeah, sorry - this is not implemented completely yet. There are some bugs which I haven't had a chance to fix there.

hello is there a way to get any CRT scanline shaders on amiberry on the Pi now?
thanks

@midwan
Copy link
Collaborator

midwan commented Dec 29, 2024

@filevans
No, that's not implemented yet. I'm hoping it will work eventually, but I haven't had enough time to learn the details of why my OpenGL implementation is broken, yet.

@filevans
Copy link

@midwan I see, please could it be looked at? As scanlines are really needed to look authentic how an Amiga used to look. Not sure if vulkan is possible instead which uses GLSL?

@midwan
Copy link
Collaborator

midwan commented Jan 12, 2025

It will be looked at, at some point. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants