-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flatnav python bindings #14
Conversation
@@ -60,7 +66,10 @@ echo "Using CC=${CC} and CXX=${CXX} compilers for building." | |||
|
|||
mkdir -p build | |||
cd build && cmake \ | |||
-DCMAKE_C_COMPILER=${CC} \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passing these here directly so that there is no confusion when someone has both GCC and clang.
CMakeLists.txt
Outdated
# In Debug mode, we will also add the -g flag to enable debugging and the | ||
# address sanitizer. | ||
message(STATUS "Building in Debug mode") | ||
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -g -fsanitize=address") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use address sanitizer only in debug builds.
flatnav_python/setup.py
Outdated
"-funroll-loops", # Unroll loops | ||
"-ftree-vectorize", # Vectorize where possible | ||
], | ||
extra_link_args=["-fopenmp"], # Link OpenMP when linking the extension |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for now this only works on Linux!
Build Python bindings for the FlatNav library. Now we can use it like this:
PR also does a few other things, mainly: