From 9f3d6b64c467cf5fd28a448d7c070bbd13a1c881 Mon Sep 17 00:00:00 2001
From: blaise-muhirwa <blaise@groundlight.ai>
Date: Thu, 30 Nov 2023 17:28:25 +0000
Subject: [PATCH] address pr comments

---
 CMakeLists.txt                                              | 2 +-
 flatnav/Index.h                                             | 2 +-
 flatnav/distances/InnerProductDistance.h                    | 6 +++---
 flatnav/distances/SquaredL2Distance.h                       | 2 +-
 flatnav/util/ExplicitSet.h                                  | 2 +-
 .../{SIMDIntrinsics.h => SIMDDistanceSpecializations.h}     | 0
 logs.txt                                                    | 3 ---
 7 files changed, 7 insertions(+), 10 deletions(-)
 rename flatnav/util/{SIMDIntrinsics.h => SIMDDistanceSpecializations.h} (100%)
 delete mode 100644 logs.txt

diff --git a/CMakeLists.txt b/CMakeLists.txt
index cb5d5c0..36d9332 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -210,7 +210,7 @@ set(HEADERS
     ${PROJECT_SOURCE_DIR}/flatnav/util/ExplicitSet.h
     ${PROJECT_SOURCE_DIR}/flatnav/util/GorderPriorityQueue.h
     ${PROJECT_SOURCE_DIR}/flatnav/util/Reordering.h
-    ${PROJECT_SOURCE_DIR}/flatnav/util/SIMDIntrinsics.h
+    ${PROJECT_SOURCE_DIR}/flatnav/util/SIMDDistanceSpecializations.h
     ${PROJECT_SOURCE_DIR}/flatnav/DistanceInterface.h
     ${PROJECT_SOURCE_DIR}/flatnav/Index.h
     ${PROJECT_SOURCE_DIR}/quantization/ProductQuantization.h
diff --git a/flatnav/Index.h b/flatnav/Index.h
index 529630e..6bb2654 100644
--- a/flatnav/Index.h
+++ b/flatnav/Index.h
@@ -10,7 +10,7 @@
 #include <flatnav/DistanceInterface.h>
 #include <flatnav/util/ExplicitSet.h>
 #include <flatnav/util/Reordering.h>
-#include <flatnav/util/SIMDIntrinsics.h>
+#include <flatnav/util/SIMDDistanceSpecializations.h>
 #include <fstream>
 #include <limits>
 #include <memory>
diff --git a/flatnav/distances/InnerProductDistance.h b/flatnav/distances/InnerProductDistance.h
index 1db37a3..38474f5 100644
--- a/flatnav/distances/InnerProductDistance.h
+++ b/flatnav/distances/InnerProductDistance.h
@@ -5,7 +5,7 @@
 #include <cstddef> // for size_t
 #include <cstring> // for memcpy
 #include <flatnav/DistanceInterface.h>
-#include <flatnav/util/SIMDIntrinsics.h>
+#include <flatnav/util/SIMDDistanceSpecializations.h>
 #include <functional>
 #include <iostream>
 #include <limits>
@@ -54,8 +54,8 @@ class InnerProductDistance : public DistanceInterface<InnerProductDistance> {
     if (Archive::is_loading::value) {
       _data_size_bytes = _dimension * sizeof(float);
       _distance_computer = std::bind(
-          &InnerProductDistance::defaultDistanceImpl, this, std::placeholders::_1,
-          std::placeholders::_2, std::placeholders::_3);
+          &InnerProductDistance::defaultDistanceImpl, this,
+          std::placeholders::_1, std::placeholders::_2, std::placeholders::_3);
 
       setDistanceFunction();
     }
diff --git a/flatnav/distances/SquaredL2Distance.h b/flatnav/distances/SquaredL2Distance.h
index 193a413..052dff1 100644
--- a/flatnav/distances/SquaredL2Distance.h
+++ b/flatnav/distances/SquaredL2Distance.h
@@ -5,7 +5,7 @@
 #include <cstddef> // for size_t
 #include <cstring> // for memcpy
 #include <flatnav/DistanceInterface.h>
-#include <flatnav/util/SIMDIntrinsics.h>
+#include <flatnav/util/SIMDDistanceSpecializations.h>
 #include <functional>
 #include <iostream>
 
diff --git a/flatnav/util/ExplicitSet.h b/flatnav/util/ExplicitSet.h
index 7ccb8de..d4676e6 100644
--- a/flatnav/util/ExplicitSet.h
+++ b/flatnav/util/ExplicitSet.h
@@ -1,6 +1,6 @@
 #pragma once
 
-#include <flatnav/util/SIMDIntrinsics.h>
+#include <flatnav/util/SIMDDistanceSpecializations.h>
 
 #include <cereal/access.hpp>
 #include <cereal/archives/binary.hpp>
diff --git a/flatnav/util/SIMDIntrinsics.h b/flatnav/util/SIMDDistanceSpecializations.h
similarity index 100%
rename from flatnav/util/SIMDIntrinsics.h
rename to flatnav/util/SIMDDistanceSpecializations.h
diff --git a/logs.txt b/logs.txt
deleted file mode 100644
index c5cccb3..0000000
--- a/logs.txt
+++ /dev/null
@@ -1,3 +0,0 @@
-Loading 128-dimensional dataset with N = 1000000
-before index initialization 
-Quantizing data