Tweaked static analysis

Author: GrahamCampbell

rector.yml

@@ -10,7 +10,6 @@ parameters:
         - 'src'
         - 'tests'
     sets:
-        - 'code-quality'
         - 'php52'
         - 'php53'
         - 'php54'
@@ -25,6 +24,52 @@ parameters:
         - 'phpunit75'
 
 services:
+    Rector\CodeQuality\Rector\Ternary\ArrayKeyExistsTernaryThenValueToCoalescingRector: ~
+    Rector\CodeQuality\Rector\FuncCall\ArrayKeysAndInArrayToArrayKeyExistsRector: ~
+    Rector\CodeQuality\Rector\FuncCall\ArrayMergeOfNonArraysToSimpleArrayRector: ~
+    Rector\CodeQuality\Rector\Identical\BooleanNotIdenticalToNotIdenticalRector: ~
+    Rector\CodeQuality\Rector\FuncCall\ChangeArrayPushToArrayAssignRector: ~
+    Rector\CodeQuality\Rector\If_\CombineIfRector: ~
+    Rector\CodeQuality\Rector\Assign\CombinedAssignRector: ~
+    Rector\CodeQuality\Rector\FuncCall\CompactToVariablesRector: ~
+    Rector\CodeQuality\Rector\Class_\CompleteDynamicPropertiesRector: ~
+    Rector\CodeQuality\Rector\If_\ConsecutiveNullCompareReturnsToNullCoalesceQueueRector: ~
+    Rector\CodeQuality\Rector\If_\ExplicitBoolCompareRector: ~
+    Rector\CodeQuality\Rector\Foreach_\ForeachToInArrayRector: ~
+    Rector\CodeQuality\Rector\FuncCall\InArrayAndArrayKeysToArrayKeyExistsRector: ~
+    Rector\CodeQuality\Rector\BinaryOp\InlineIfToExplicitIfRector: ~
+    Rector\CodeQuality\Rector\FuncCall\IntvalToTypeCastRector: ~
+    Rector\CodeQuality\Rector\FuncCall\IsAWithStringWithThirdArgumentRector: ~
+    Rector\CodeQuality\Rector\If_\RemoveAlwaysTrueConditionSetInConstructorRector: ~
+    Rector\CodeQuality\Rector\FuncCall\RemoveSoleValueSprintfRector: ~
+    Rector\CodeQuality\Rector\If_\ShortenElseIfRector: ~
+    Rector\CodeQuality\Rector\Identical\SimplifyArraySearchRector: ~
+    Rector\CodeQuality\Rector\Identical\SimplifyBoolIdenticalTrueRector: ~
+    Rector\CodeQuality\Rector\Identical\SimplifyConditionsRector: ~
+    Rector\CodeQuality\Rector\Ternary\SimplifyDuplicatedTernaryRector: ~
+    Rector\CodeQuality\Rector\Foreach_\SimplifyForeachToCoalescingRector: ~
+    Rector\CodeQuality\Rector\If_\SimplifyIfElseToTernaryRector: ~
+    Rector\CodeQuality\Rector\If_\SimplifyIfIssetToNullCoalescingRector: ~
+    Rector\CodeQuality\Rector\If_\SimplifyIfNotNullReturnRector: ~
+    Rector\CodeQuality\Rector\If_\SimplifyIfReturnBoolRector: ~
+    Rector\CodeQuality\Rector\FuncCall\SimplifyInArrayValuesRector: ~
+    Rector\CodeQuality\Rector\FuncCall\SimplifyStrposLowerRector: ~
+    Rector\CodeQuality\Rector\Ternary\SimplifyTautologyTernaryRector: ~
+    Rector\CodeQuality\Rector\Return_\SimplifyUselessVariableRector: ~
+    Rector\CodeQuality\Rector\FuncCall\SingleInArrayToCompareRector: ~
+    Rector\CodeQuality\Rector\Assign\SplitListAssignToSeparateLineRector: ~
+    Rector\CodeQuality\Rector\FuncCall\StrlenZeroToIdenticalEmptyStringRector: ~
+    Rector\CodeQuality\Rector\Ternary\UnnecessaryTernaryExpressionRector: ~
+    Rector\CodeQuality\Rector\Equal\UseIdenticalOverEqualWithSameTypeRector: ~
+    Rector\CodingStyle\Rector\FuncCall\ConsistentImplodeRector: ~
+    Rector\CodingStyle\Rector\Encapsed\EncapsedStringsToSprintfRector: ~
+    Rector\CodingStyle\Rector\FuncCall\FunctionCallToConstantRector: ~
+    Rector\CodingStyle\Rector\ClassMethod\MakeInheritedMethodVisibilitySameAsParentRector: ~
+    Rector\CodingStyle\Rector\If_\NullableCompareToNullRector: ~
+    Rector\CodingStyle\Rector\FuncCall\SimpleArrayCallableToStringRector: ~
+    Rector\CodingStyle\Rector\ClassConst\SplitGroupedConstantsAndPropertiesRector: ~
+    Rector\CodingStyle\Rector\ClassConst\VarConstantCommentRector: ~
+    Rector\CodingStyle\Rector\FuncCall\VersionCompareFuncCallToConstantRector: ~
     Rector\DeadCode\Rector\If_\RemoveAlwaysTrueIfConditionRector: ~
     Rector\DeadCode\Rector\BooleanAnd\RemoveAndTrueRector: ~
     Rector\DeadCode\Rector\Assign\RemoveAssignOfVoidReturnFunctionRector: ~
@@ -55,5 +100,3 @@ services:
     Rector\SOLID\Rector\If_\ChangeIfElseValueAssignToEarlyReturnRector: ~
     Rector\SOLID\Rector\If_\ChangeNestedIfsToEarlyReturnRector: ~
     Rector\SOLID\Rector\If_\RemoveAlwaysElseRector: ~
-    Rector\SOLID\Rector\Property\ChangeReadOnlyPropertyWithDefaultValueToConstantRector: ~
-    Rector\TypeDeclaration\Rector\FunctionLike\ParamTypeDeclarationRector: ~

vendor-bin/phpstan/composer.json

@@ -1,8 +1,8 @@
 {
     "require": {
         "phpstan/phpstan": "~0.12.33",
-        "phpstan/phpstan-deprecation-rules": "~0.12.4",
-        "phpstan/phpstan-strict-rules": "~0.12.3",
+        "phpstan/phpstan-deprecation-rules": "~0.12.5",
+        "phpstan/phpstan-strict-rules": "~0.12.4",
         "thecodingmachine/phpstan-strict-rules": "~0.12.0",
         "ergebnis/phpstan-rules": "~0.15.0"
     },

vendor-bin/rector/composer.json

@@ -1,6 +1,14 @@
 {
     "require": {
-        "rector/rector": "~0.7.48"
+        "phpstan/phpstan": "0.12.32",
+        "rector/rector": "0.7.48",
+        "symplify/auto-bind-parameter": "8.1.13",
+        "symplify/autowire-array-parameter": "8.1.13",
+        "symplify/console-color-diff": "8.1.13",
+        "symplify/package-builder": "8.1.13",
+        "symplify/parameter-name-guard": "8.1.13",
+        "symplify/set-config-resolver": "8.1.13",
+        "symplify/smart-file-system": "8.1.13"
     },
     "config": {
         "preferred-install": "dist"