investigate

Author: justing-bq

cpp/src/arrow/flight/sql/odbc/odbc_impl/system_dsn.cc

@@ -20,6 +20,7 @@
 #include "arrow/result.h"
 #include "arrow/util/utf8.h"
 
+#include <iostream>
 #include <sstream>
 
 namespace arrow::flight::sql::odbc {
@@ -77,15 +78,24 @@ bool UnregisterDsn(const std::wstring& dsn) {
  * @return True on success and false on fail.
  */
 bool RegisterDsn(const Configuration& config, LPCWSTR driver) {
+  std::cout << "Undahbile: Registering DSN: " << config.Get(FlightSqlConnection::DSN)
+            << std::endl;
+
   const std::string& dsn = config.Get(FlightSqlConnection::DSN);
+  std::cout << "Undahbile: Using dsn = " << dsn << std::endl;
+
   auto wdsn_result = arrow::util::UTF8ToWideString(dsn);
+  std::cout << "Undahbile: Converted wdsn_result" << std::endl;
   if (!wdsn_result.status().ok()) {
+    std::cout << "Undahbile: Error converting wdsn_result" << std::endl;
     PostArrowUtilError(wdsn_result.status());
     return false;
   }
-  std::wstring wdsn = wdsn_result.ValueOrDie();
 
+  std::wstring wdsn = wdsn_result.ValueOrDie();
+  std::wcout << "Undahbile: Converted wdsn = " << wdsn << std::endl;
   if (!SQLWriteDSNToIni(wdsn.c_str(), driver)) {
+    std::cout << "Undahbile: Error writing DSN to ini" << std::endl;
     PostLastInstallerError();
     return false;
   }
@@ -100,25 +110,28 @@ bool RegisterDsn(const Configuration& config, LPCWSTR driver) {
 
     auto wkey_result = arrow::util::UTF8ToWideString(key);
     if (!wkey_result.status().ok()) {
+      std::cout << "Undahbile: Error converting wkey_result = " <<  wkey_result.status().message() << std::endl;
       PostArrowUtilError(wkey_result.status());
       return false;
     }
     std::wstring wkey = wkey_result.ValueOrDie();
 
     auto wvalue_result = arrow::util::UTF8ToWideString(it->second);
     if (!wvalue_result.status().ok()) {
+      std::cout << "Undahbile: Error converting wvalue_result = " <<  wvalue_result.status().message() << std::endl;
       PostArrowUtilError(wvalue_result.status());
       return false;
     }
     std::wstring wvalue = wvalue_result.ValueOrDie();
-
     if (!SQLWritePrivateProfileString(wdsn.c_str(), wkey.c_str(), wvalue.c_str(),
                                       L"ODBC.INI")) {
+      std::cout << "Undahbile: Error writing private profile string" << std::endl;
       PostLastInstallerError();
       return false;
     }
   }
 
+  std::cout << "Undahbile: Successfully registered DSN" << std::endl;
   return true;
 }
 }  // namespace arrow::flight::sql::odbc

cpp/src/arrow/flight/sql/odbc/tests/odbc_test_suite.cc

@@ -26,6 +26,8 @@
 #include "arrow/flight/sql/odbc/odbc_impl/encoding_utils.h"
 #include "arrow/flight/sql/odbc/odbc_impl/odbc_connection.h"
 
+#include <iostream>
+
 namespace arrow::flight::sql::odbc {
 
 void ODBCRemoteTestBase::AllocEnvConnHandles(SQLINTEGER odbc_ver) {
@@ -42,12 +44,15 @@ void ODBCRemoteTestBase::AllocEnvConnHandles(SQLINTEGER odbc_ver) {
 }
 
 void ODBCRemoteTestBase::Connect(SQLINTEGER odbc_ver) {
+  std::cout << "Undahbile: ODBCRemoteTestBase::Connect()" << std::endl;
   ASSERT_NO_FATAL_FAILURE(AllocEnvConnHandles(odbc_ver));
   std::string connect_str = GetConnectionString();
   ASSERT_NO_FATAL_FAILURE(ConnectWithString(connect_str));
 }
 
 void ODBCRemoteTestBase::ConnectWithString(std::string connect_str) {
+  std::cout << "Undahbile: ODBCRemoteTestBase::ConnectWithString() with connect_str = " << connect_str << std::endl;
+
   // Connect string
   std::vector<SQLWCHAR> connect_str0(connect_str.begin(), connect_str.end());
 
@@ -61,6 +66,8 @@ void ODBCRemoteTestBase::ConnectWithString(std::string connect_str) {
                              kOdbcBufferSize, &out_str_len, SQL_DRIVER_NOPROMPT))
       << GetOdbcErrorMessage(SQL_HANDLE_DBC, conn);
 
+  std::cout << "Undahbile: Connected to ODBC server successfully" << std::endl;
+
   ASSERT_EQ(SQL_SUCCESS, SQLAllocHandle(SQL_HANDLE_STMT, conn, &stmt));
 }
 
@@ -370,7 +377,9 @@ void ODBCMockTestBase::SetUp() {
 }
 
 void FlightSQLODBCMockTestBase::SetUp() {
+  std::cout << "Undahbile: FlightSQLODBCMockTestBase::SetUp()" << std::endl;
   ODBCMockTestBase::SetUp();
+  std::cout << "Undahbile: After ODBCMockTestBase::SetUp()" << std::endl;
   this->Connect();
   connected_ = true;
 }