api-gateway lacks a global request id in logs for cross-service correlation

[therealjhay]

ProblemEach service logs its own ids; without a shared header propagation, tracing a payment across gateway → settlement → indexer is manual.

1. No distributed request-id header.
2. Logs not correlated.
3. Troubleshooting slow.

Solution

• Propagate a trace/request id across service boundaries.
• Log it consistently.
• Test propagation.

Acceptance Criteria

• One id correlates a request across services.
• Logs carry it.
• pnpm build passes.

Note for Contributors: Write a clear PR description. Show a correlated trace across services.

[thegreatfeez]

Hello, I would like to work on tis issue

[grantfox-oss]

🦊 GrantFox — @thegreatfeez has been assigned to this issue as part of the Third Campaign campaign!

Next steps:

1. Open a Pull Request referencing this issue (e.g., Closes #568)
2. Your PR will be reviewed by the Betta-Pay maintainers

Good luck! Track your progress on GrantFox.

[thegreatfeez]

This appears to already be implemented on main. Cross-service request-id / trace-id propagation and consistent logging were delivered under #118 (distributed tracing) and #119 (structured logging), and the api-gateway is wired into both.

Mapping to the acceptance criteria in this issue:

One id correlates a request across services

• shared/validation/tracing.ts — propagateTracingHeaders() (line 49) copies x-request-id and x-trace-id onto outbound inter-service calls, and registerTracing() (line 67) mints a trace id at the gateway edge when absent and keeps it stable across hops.
• Every downstream client propagates them: services/api-gateway/src/clients/settlement-client.ts:64, clients/fx-client.ts:87, clients/indexer-client.ts:97, and services/api-gateway/src/upstream-fetch.ts:96.

Logs carry it

• api-gateway builds Fastify with the shared Pino logger and registers both plugins in services/api-gateway/src/index.ts:383-385 (registerRequestId, registerTracing).
• The shared logger serializer emits requestId on every request line (shared/validation/logger.ts:69-70), and registerTracing binds requestId + traceId to the request logger (shared/validation/tracing.ts:78).
• All four services register both plugins: api-gateway (383/385), settlement-engine (144/175), fx-engine (740/833), indexer (80/122).

pnpm build passes

• The above is already merged on main, which CI builds and tests on every push, so no new code is required to satisfy this.

Propagation is also already covered by tests:

• shared/validation/tracing.test.ts
• services/api-gateway/src/clients/{settlement,fx,indexer}-client.test.ts
• test/contracts/{settlement,fx,indexer}-client.contract.test.ts
• services/api-gateway/src/warmup-downstream.test.ts

Given all of the above, this looks like a duplicate of #118 / #119 and can probably be closed. Happy to pick it up if there's a specific gap in the current implementation that I've missed.