Skip to content

fx-engine quote handler computes rates twice (cache + live fallback) #566

Description

@therealjhay

ProblemThe quote handler reads the cache and, on miss, fetches live; two paths recompute amounts and can return different results for the same request.

  1. Duplicated quote computation.
  2. Live-fallback path untested in fx-quote-* tests.
  3. Inconsistent rounding across paths.

Solution

  • Single quote computation path with cache-or-live resolution.
  • Test the fallback path.
  • Unify rounding.

Acceptance Criteria

  • One computation path.
  • Fallback tested.
  • pnpm --filter fx-engine build passes.

Note for Contributors: Write a clear PR description. Show identical results from cache and fallback.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

GrantFox OSSIssue tracked in GrantFox OSSMaybe RewardedIssue may be eligible for a GrantFox rewardThird CampaignCampaign: Third Campaign

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions