Skip to content

[Bug]: Can't modify models settings on UI (Edit Option) #9111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MattCarneiro opened this issue Mar 10, 2025 · 12 comments · Fixed by #10853
Closed

[Bug]: Can't modify models settings on UI (Edit Option) #9111

MattCarneiro opened this issue Mar 10, 2025 · 12 comments · Fixed by #10853
Assignees
Labels
bug Something isn't working

Comments

@MattCarneiro
Copy link

What happened?

A bug happened!

If I select a model and click on edit icon, there's a button called Edit Model. If I press it and try to modify model name or public name and save. It saves but after refresh the page, the public model name still the same. Same if I try to update via API. It changes on patch request but then after refresh it stays the same public name

Relevant log output

Are you a ML Ops Team?

No

What LiteLLM version are you on ?

v1.63.3 (main-latest)

Twitter / LinkedIn details

No response

@MattCarneiro MattCarneiro added the bug Something isn't working label Mar 10, 2025
@krrishdholakia
Copy link
Contributor

Hey @MattCarneiro is this on a db model or config model?

@MattCarneiro
Copy link
Author

Hey @MattCarneiro is this on a db model or config model?

DB model

@MattCarneiro
Copy link
Author

MattCarneiro commented Mar 10, 2025

I noticed something strange. If I update public name via API on (main-latest) version, it doesn't change anything. At least on UI still the old public name and if I do a Get request still the old name. However, if I downgrade to (main-stable) version, it shows the new updated name under the model public name.

@krrishdholakia
Copy link
Contributor

what's the version of main-stable?

@MattCarneiro
Copy link
Author

what's the version of main-stable?

1.53.7

@krrishdholakia
Copy link
Contributor

got it - able to repro this on the latest stable - v1.63.2 (it's moved to being from the stable release branch)

Will push a fix for this

@krrishdholakia
Copy link
Contributor

Thank you for your help on this @MattCarneiro

@MattCarneiro
Copy link
Author

Thank you for your help on this @MattCarneiro

nice! please tell me when you fix it and which version

@krrishdholakia
Copy link
Contributor

cc: @ishaan-jaff

@MattCarneiro
Copy link
Author

cc: @ishaan-jaff

latest stable version the problem remains

@MattCarneiro
Copy link
Author

Problem persists on latest stable @krrishdholakia released today

@MattCarneiro
Copy link
Author

so? @krrishdholakia @ishaan-jaff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants