Skip to content

[Feature]: Allow include block in config to work with S3/GCS buckets #10632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bharat23 opened this issue May 7, 2025 · 3 comments · May be fixed by #10765
Open

[Feature]: Allow include block in config to work with S3/GCS buckets #10632

Bharat23 opened this issue May 7, 2025 · 3 comments · May be fixed by #10765
Labels
enhancement New feature or request

Comments

@Bharat23
Copy link

Bharat23 commented May 7, 2025

The Feature

Currently, the include block works fine when using the LFS to access the config and can look up the included files. However, when using an S3/GCS bucket to load the config, the include is not considered.

What should happen:

  • It should make consequent requests to fetch the included keys/files from the bucket

Proposal:

  • Use the bucket name and path specified in the config to download all the files in the include, and create a final config object. When using include, the path should be relative to the bucket i.e. bucket key.

Motivation, pitch

We use an S3 bucket to load our config as it allows us to not rebuild Docker images again and again. Given we have 20+ models in our config, we wanted to leverage include, which unfortunately doesn't work as expected and we end up not loading any models.

Are you a ML Ops Team?

No

Twitter / LinkedIn details

https://www.linkedin.com/in/bharatsinha23/

@Bharat23 Bharat23 added the enhancement New feature or request label May 7, 2025
@Bharat23
Copy link
Author

Bharat23 commented May 7, 2025

I'd be willing to work on this and create a PR if we are fine with the proposal.

@Bharat23
Copy link
Author

@ishaan-jaff @krrishdholakia Thoughts?

@krrishdholakia
Copy link
Contributor

Hey @Bharat23 this looks like a great idea - a PR here is welcome!

@Bharat23 Bharat23 linked a pull request May 12, 2025 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants