Skip to content

Commit d5c19d3

Browse files
arnaud-rolandThomasMengelatte
authored andcommitted
push: remove android notification type enum
1 parent 63c8ef1 commit d5c19d3

File tree

2 files changed

+1
-13
lines changed

2 files changed

+1
-13
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ ___
1010
**Push**
1111
- Added `setShowNotifications` method to control whether android push notifications should be displayed.
1212
- Added `shouldShowNotifications` method to check current android notification display settings.
13-
- Removed `setNotificationTypes` method. You should now use `setShowNotifications` to control whether Batch should display notifications or not. Note that Batch still preserves your previous values and `shouldShowNotifications` will reflect them.
13+
- Removed `AndroidNotificationTypes` enum and related method `setNotificationTypes`. You should now use `setShowNotifications` to control whether Batch should display notifications or not. Note that Batch still preserves your previous values and `shouldShowNotifications` will reflect them.
1414

1515
**Messaging**
1616
- Added support for Mobile Landings within the Customer Engagement Platform.

src/BatchPush.ts

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -4,28 +4,16 @@ import { BatchEventEmitter, EmitterSubscription } from './BatchEventEmitter';
44

55
const RNBatch = require('./NativeRNBatchModule').default;
66

7-
export interface IAndroidNotificationTypes {
8-
NONE: number;
9-
SOUND: number;
10-
VIBRATE: number;
11-
LIGHTS: number;
12-
ALERT: number;
13-
}
14-
157
export interface BatchPushEventPayload {
168
isPositiveAction: boolean;
179
pushPayload: Record<string, unknown>;
1810
deeplink?: string | null;
1911
}
2012

21-
export const AndroidNotificationTypes: IAndroidNotificationTypes = RNBatch.getConstants().NOTIFICATION_TYPES;
22-
2313
/**
2414
* Batch's push module
2515
*/
2616
export const BatchPush = {
27-
AndroidNotificationTypes,
28-
2917
/**
3018
* Ask users if they want to accept push notifications.
3119
* Required to be able to push users (or use requestProvisionalNotificationAuthorization - ios only).

0 commit comments

Comments
 (0)