Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Pagination #242

Closed
Bashamega opened this issue Aug 4, 2024 · 10 comments · Fixed by #249
Closed

Integrate Pagination #242

Bashamega opened this issue Aug 4, 2024 · 10 comments · Fixed by #249
Labels

Comments

@Bashamega
Copy link
Owner

Describe the bug
The GitHub Issue finder is missing the pagination option.

Copy link
Contributor

github-actions bot commented Aug 4, 2024

Hello! 👋 Thanks for opening this issue. We appreciate your feedback and will look into it as soon as possible. Feel free to add more details if necessary.

@RieBi
Copy link
Contributor

RieBi commented Aug 4, 2024

Hello, I would like to contribute to this thing. So, If I understand correctly, github issue finder looks for the newest issues on github and displays them? But right now there's only a limited amount of issues displayed, and there should be more pages which would displays more things. Is that how it's intended to be?

@RieBi
Copy link
Contributor

RieBi commented Aug 4, 2024

@Bashamega

@Bashamega
Copy link
Owner Author

Hello, I would like to contribute to this thing. So, If I understand correctly, github issue finder looks for the newest issues on github and displays them? But right now there's only a limited amount of issues displayed, and there should be more pages which would displays more things. Is that how it's intended to be?

Correct.
Also please don't ping me. I will see your notification

@RieBi
Copy link
Contributor

RieBi commented Aug 4, 2024

How do you set up so that the issue finder works locally? When I try to use it, and request to github api is sent, it says that api limit is reached. Is there some authentication needed to be done in order for it to work?

@RieBi
Copy link
Contributor

RieBi commented Aug 4, 2024

Ah, nevermind, the gh-finder on your hosted site doesn't work for me either now

@RieBi
Copy link
Contributor

RieBi commented Aug 4, 2024

So, the requests to the API are send without any authentication, and limit is very low. So basically very soon it stops working when using it. You have caching for results, but I somehow exceeded limits even with it

@Bashamega
Copy link
Owner Author

Ah, nevermind, the gh-finder on your hosted site doesn't work for me either now

You might have hit the rate limit. You can wait for like 24 hours. Then It will work. Or use a different ip address

@RieBi
Copy link
Contributor

RieBi commented Aug 4, 2024

You might have hit the rate limit. You can wait for like 24 hours. Then It will work. Or use a different ip address

Yeah, I see. So, the limit for unauthenticated users is 60 requests per hour.

So, there are big issues with the gh-finder. Specifically, fetching PRs to issues is broken. It would do it too often and overall doesn't really work. There are some other things.

I hope you don't mind if in the process I might not just add paging, but add lots of other stuff, mainly fixing the whole thing.

@Bashamega
Copy link
Owner Author

You might have hit the rate limit. You can wait for like 24 hours. Then It will work. Or use a different ip address

Yeah, I see. So, the limit for unauthenticated users is 60 requests per hour.

So, there are big issues with the gh-finder. Specifically, fetching PRs to issues is broken. It would do it too often and overall doesn't really work. There are some other things.

I hope you don't mind if in the process I might not just add paging, but add lots of other stuff, mainly fixing the whole thing.

I would love that. Thank you very much. If you want help, I can help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants