Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: conversion calculator incorrectly converting the values #214

Closed
barefootstache opened this issue Jul 23, 2024 · 3 comments · Fixed by #221
Closed

Bug: conversion calculator incorrectly converting the values #214

barefootstache opened this issue Jul 23, 2024 · 3 comments · Fixed by #221
Assignees
Labels
bug Something isn't working Eddiehub:good-first-issue

Comments

@barefootstache
Copy link

Describe the bug

There are multiple bugs on page https://wdt.adambashaahmednaji.com/customizer/conversionCalculator.

Bug 1

The button name at the top left is Web Dev Tool Button customizer instead of Web Dev Tool Conversion Calculator.

Bug 2

  1. Setup the original two buttons chosen are both cm.
  2. Change the second button to km.
  3. Bug: no on change event is being triggered and first gets triggered when changing the value.
  4. Possible Fix: create an on change event on the dropdown button.

Bug 3

  1. Setup the original two buttons chosen are both cm.
  2. Change the second button to km.
  3. Increase the value of the first input field by one.
  4. Bug: the input value over the second button is only correct when rounding.
  5. Possible Fix: add more float precision dependent on the conversion choice.

Bug 4

  1. Setup the original two buttons chosen are both cm.
  2. Change the second button to km.
  3. Increase the value of the first input field by one.
  4. Change the second button back to cm.
  5. Bug: input value over the second button changes, though to the wrong value.

Bug 5

  1. Setup the original two buttons chosen are both cm.
  2. Change the second button to km.
  3. Increase the value of the first input field by one.
  4. Change the second button back to cm.
  5. Increase the value of the first input field by one.
  6. Bug: the two values should be equal, though they differ by one.

Bug 6

  1. Setup the original two buttons chosen are both cm.
  2. Enter any number into the first input and confirm with ENTER key.
  3. Bug: no update is shown in the second input.

Desktop (please complete the following information):

  • OS: Fedora 40
  • Browser: Firefox
  • Version: 128.0

Additional context

There are multiple bugs on this page and can be easily be resolved in one sweep by adding multiple event handlers.

Copy link
Contributor

Hello! 👋 Thanks for opening this issue. We appreciate your feedback and will look into it as soon as possible. Feel free to add more details if necessary.

@Bashamega
Copy link
Owner

Would you like to work on this?

@barefootstache
Copy link
Author

@Bashamega not particularly, though can continue doing QA (quality assurance). From the brief look over the repo, there are lots that can be improved upon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Eddiehub:good-first-issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants