lib/utilities: code style cleanup

Instead of `sort | uniq` (or worse: `uniq | sort`!), use `sort -u`.

Alsö, lose `tr '\n' ' '` as it does ń̥otḩing since `$IFS` contains both space and new line (and tab).

No need to pipe to `cat` then redirect to disk. Just redirect directly to the file without `cat` at all.

Author: gaelicWizard

lib/utilities.bash

@@ -54,7 +54,7 @@ _bash-it-array-contains-element() {
 
 # Dedupe a simple array of words without spaces.
 _bash-it-array-dedup() {
-  echo "$*" | tr ' ' '\n' | sort -u | tr '\n' ' '
+  echo "$*" | tr ' ' '\n' | sort -u
 }
 
 # Outputs a full path of the grep found on the filesystem
@@ -77,7 +77,7 @@ _bash-it-component-help() {
   if [[ ! -s "${file}" || -z "$(find "${file}" -mmin -300)" ]] ; then
     rm -f "${file}" 2>/dev/null
     local func="_bash-it-${component}"
-    ${func} | $(_bash-it-grep) -E '   \[' | cat > "${file}"
+    ${func} | $(_bash-it-grep) -E '   \[' > "${file}"
   fi
   cat "${file}"
 }
@@ -117,23 +117,23 @@ _bash-it-clean-component-cache() {
 # Returns an array of items within each compoenent.
 _bash-it-component-list() {
   local component="$1"
-  _bash-it-component-help "${component}" | awk '{print $1}' | uniq | sort | tr '\n' ' '
+  _bash-it-component-help "${component}" | awk '{print $1}' | sort -u
 }
 
 _bash-it-component-list-matching() {
   local component="$1"; shift
   local term="$1"
-  _bash-it-component-help "${component}" | $(_bash-it-grep) -E -- "${term}" | awk '{print $1}' | sort | uniq
+  _bash-it-component-help "${component}" | $(_bash-it-grep) -E -- "${term}" | awk '{print $1}' | sort -u
 }
 
 _bash-it-component-list-enabled() {
   local component="$1"
-  _bash-it-component-help "${component}" | $(_bash-it-grep) -E  '\[x\]' | awk '{print $1}' | uniq | sort | tr '\n' ' '
+  _bash-it-component-help "${component}" | $(_bash-it-grep) -E  '\[x\]' | awk '{print $1}' | sort -u
 }
 
 _bash-it-component-list-disabled() {
   local component="$1"
-  _bash-it-component-help "${component}" | $(_bash-it-grep) -E -v '\[x\]' | awk '{print $1}' | uniq | sort | tr '\n' ' '
+  _bash-it-component-help "${component}" | $(_bash-it-grep) -E -v '\[x\]' | awk '{print $1}' | sort -u
 }
 
 # Checks if a given item is enabled for a particular component/file-type.