Skip to content

Remove owned correction links when forgetting support history - #74

Merged
aryanorastar merged 9 commits into
mainfrom
fix/knowledge-privacy-erasure
Oct 23, 2026
Merged

aryanorastar merged 9 commits into
mainfrom
fix/knowledge-privacy-erasure

Conversation

@aryanorastar

@aryanorastar aryanorastar commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

Customer failure prevented

Forgetting support history must also remove the customer's verified internal links to reviewed corrections, without erasing another scope or claiming complete deletion after failure.

Integrated current main 94e4f5762748590ca46f8e4a00690c808c6e38eb (#67) with merge commit 7860417. Parent #49 is merged. All three release smokes have passed; the reviewer authorizes #67 then #74 merges once final checks pass. No new-code deployment or memory/context/fix-inbox enablement is authorized by this merge.

Changes and limits

  • Derive nullable server/forum case metadata from configured post-owner scope; no text or guessed legacy scope, no known-case rebinding.
  • Commit forum-wide memory erasure/opt-out first, then remove only verified matching internal correction links. Preserve independent facts, approvals/revocation and other owners/forums/servers.
  • Existing durable opt-out and guild/fact locks fence late/new-case writers. Mandatory retention retries cleanup; no second opt-out store.
  • Bounded passes and transaction-local SQL deadlines. Unknown legacy/orphan links/markers, incomplete work and DB errors refuse a full-deletion claim; memory opt-out survives later failure.
  • Operational cases, Discord messages, backups and independent product knowledge are not deleted. This is not account erasure, enabled learning or a complete privacy/pilot approval.

Verification

  • Current head 5e6707c2e9f7617b5ae16a5dccc6bdd20215e5e3: 952/952 npm tests, fresh before push. Integration offline customer eval 8/8 and combined isolated SQL pass.
  • Critical privacy runtime files and focused tests byte-identical to reviewed dfc13988413bf1bfd963e637f70017b5229527b9; only document conflicts needed resolution. Existing main recovery, deadlines and memory rehearsals retained.
  • Initial independent foundation review passed; earlier integration passed77 checks. Current Keep ordinary support and failed follow-ups in the same thread #67 integration re-review at7860417 passes 298 affected checks; operative docs were refreshed to record accepted smokes and remove the stale merge hold. Runtime is unchanged by that final documentation commit.
  • Exact-head hosted Node 20, Node 24 and real PostgreSQL pass, run 39986598464.
  • Original nine focused regressions include eight observed baseline failures; SQL also failed before the repair. Covers 101 facts/two passes, other scopes and fact preservation, commit-before-ack, late/new-case writers, retry/idempotence, concurrent writing and strict legacy/orphan/marker refusal. PGlite is serial evidence; hosted PostgreSQL covers multi-connection behavior.

No new provider run, protected-input read, customer-data access, production DB operation, Discord post, setting/permission change or optional enablement. Full privacy/security/data-use/backup and enabled-pilot gates remain. Product progress stays 47/100, not accuracy.

@aryanorastar

Copy link
Copy Markdown
Collaborator Author

Independent review completed at dfc1398: PASS for the disabled foundation integration, no actionable findings. Fresh 76 affected tests and isolated SQL pass; exact-head Node 20/24/PostgreSQL run 39554963703 is green and explicitly executes the new scoped-erasure group. Review verified owner/configured-forum scope, memory erasure/opt-out committed before acknowledgment, other-scope preservation, late/concurrent writer fencing, retry, and refusal to claim complete deletion for partial/outage/unknown legacy results. Parent #49 also passed foundation review. Keep the parent integration/current-head CI requirement explicit before merging; this does not approve enabled memory, legacy reconciliation, real ingestion/validation or a live pilot. No production/customer/provider/Discord operation occurred.

Base automatically changed from feat/fix-inbox to main October 23, 2026 13:09
@aryanorastar
aryanorastar marked this pull request as ready for review October 23, 2026 16:26
@aryanorastar
aryanorastar merged commit d108e1a into main Oct 23, 2026
3 checks passed
@aryanorastar
aryanorastar deleted the fix/knowledge-privacy-erasure branch October 23, 2026 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant