fix(loc-cap): move static cheats to challenge-ast; drop submit shim

Keep prism-challenge and challenge-agentic under the 1500 LOC gate while
preserving pre-pod static screens and GatewayClient via challenge-common.

Author: echobt

crates/challenge-agentic/src/lib.rs

@@ -18,16 +18,17 @@ mod agent;
 mod llm;
 mod prompts;
 mod sim;
-mod static_checks;
 mod tools;
 mod types;
 
 pub use agent::{AgentConfig, OpenRouterAgent};
-pub use challenge_ast::{copy_gate, CopyGateHit, GateCorpusEntry};
+pub use challenge_ast::{
+    copy_gate, static_source_cheat, training_has_telemetry_hooks, CopyGateHit, GateCorpusEntry,
+    SourceCheatHit, SourceCheatKind,
+};
 pub use llm::{load_api_key_file, DEFAULT_MODEL};
 pub use prompts::{AGENTIC_PROMPT_VERSION, DESIGN_DOMAIN_RULES, PRISM_DOMAIN_RULES};
 pub use sim::{SimAgent, SIM_CHEAT_BPS, SIM_SUSPICIOUS_BPS};
-pub use static_checks::{static_source_cheat, training_has_telemetry_hooks, StaticCheatHit};
 pub use types::{
     AgenticBackend, AgenticError, AgenticVerdict, CheatCode, ContainerReviewRequest, CorpusEntry,
     ReviewRequest, VerdictKind, OPENROUTER_API_BASE,

crates/challenge-agentic/src/sim.rs

@@ -79,10 +79,6 @@ impl AgenticBackend for SimAgent {
             return Ok(v);
         }
 
-        // Source-only screens are also available via [`crate::static_source_cheat`]
-        // for the pre-pod orchestrator path; sim keeps the in-review copies so
-        // metrics-relative checks and corpus AST still share one backend.
-
         if let Some(v) = pages_scrape_cheat_verdict(req)? {
             return Ok(v);
         }
@@ -191,7 +187,7 @@ fn telemetry_hooks_verdict(
         return None;
     }
     let (path, src) = primaries.iter().find(|(p, _)| p.ends_with("training.py"))?;
-    if crate::training_has_telemetry_hooks(src) {
+    if challenge_ast::training_has_telemetry_hooks(src) {
         return None;
     }
     Some(AgenticVerdict {

crates/challenge-ast/src/lib.rs

@@ -9,6 +9,7 @@
 mod fingerprint;
 mod gate;
 mod similarity;
+mod source_cheats;
 mod walk;
 
 pub use fingerprint::{fingerprint_source, AstError, Fingerprint};
@@ -19,6 +20,9 @@ pub use gate::{
 pub use similarity::{
     similarity_bps, structural_diff_summary, summarize_fingerprint, top_k_nearest, Neighbor,
 };
+pub use source_cheats::{
+    static_source_cheat, training_has_telemetry_hooks, SourceCheatHit, SourceCheatKind,
+};
 
 /// Crate identity smoke.
 #[must_use]

…s/challenge-agentic/src/static_checks.rs crates/challenge-ast/src/source_cheats.rscrates/challenge-agentic/src/static_checks.rs renamed to crates/challenge-ast/src/source_cheats.rs crates/challenge-agentic/src/static_checks.rs renamed to crates/challenge-ast/src/source_cheats.rs

@@ -1,40 +1,40 @@
 //! Cheap source-only cheat screens (no GPU, no private eval assets).
-//!
-//! Run these **before** renting a Lium pod so a bad submission fails fast
-//! instead of burning hours of GPU. Metrics/receipt consistency checks stay
-//! post-eval (they need harness output).
 
-use crate::types::CheatCode;
+/// Kind of static source hit (maps to agentic `CheatCode` at the call site).
+#[derive(Debug, Clone, Copy, PartialEq, Eq)]
+pub enum SourceCheatKind {
+    /// Hardcoded `METRICS_JSON=` short-circuit.
+    EvalShortCircuit,
+    /// Missing Prism telemetry hooks in `training.py`.
+    MissingTelemetryHooks,
+}
 
 /// One static source finding.
 #[derive(Debug, Clone, PartialEq, Eq)]
-pub struct StaticCheatHit {
-    /// Cheat taxonomy code.
-    pub code: CheatCode,
+pub struct SourceCheatHit {
+    /// Cheat kind.
+    pub kind: SourceCheatKind,
     /// Human-readable reason (safe to surface in `error_detail`).
     pub rationale: String,
 }
 
 /// Scan miner sources for cheap, deterministic cheat patterns.
-///
-/// Order: hardcoded `METRICS_JSON=` short-circuit first, then missing Prism
-/// telemetry hooks in `training.py`. Returns the first hit.
 #[must_use]
-pub fn static_source_cheat(architecture_py: &str, training_py: &str) -> Option<StaticCheatHit> {
+pub fn static_source_cheat(architecture_py: &str, training_py: &str) -> Option<SourceCheatHit> {
     for (path, src) in [
         ("architecture.py", architecture_py),
         ("training.py", training_py),
     ] {
         if src.contains("METRICS_JSON=") {
-            return Some(StaticCheatHit {
-                code: CheatCode::EvalShortCircuit,
+            return Some(SourceCheatHit {
+                kind: SourceCheatKind::EvalShortCircuit,
                 rationale: format!("static: hardcoded METRICS_JSON in {path}"),
             });
         }
     }
     if !training_has_telemetry_hooks(training_py) {
-        return Some(StaticCheatHit {
-            code: CheatCode::MissingTelemetryHooks,
+        return Some(SourceCheatHit {
+            kind: SourceCheatKind::MissingTelemetryHooks,
             rationale: "static: training.py missing prism_telemetry report/finish_evaluation hooks"
                 .into(),
         });
@@ -48,9 +48,7 @@ pub fn training_has_telemetry_hooks(training_py: &str) -> bool {
     let imports_shim = training_py.contains("prism_telemetry")
         || training_py.contains("ctx[\"telemetry\"]")
         || training_py.contains("ctx['telemetry']");
-    let calls_report = training_py.contains(".report(");
-    let calls_finish = training_py.contains("finish_evaluation(");
-    imports_shim && calls_report && calls_finish
+    training_py.contains(".report(") && training_py.contains("finish_evaluation(") && imports_shim
 }
 
 #[cfg(test)]
@@ -64,7 +62,7 @@ mod tests {
             "def train(m, ctx):\n    print('METRICS_JSON={}')\n",
         )
         .expect("hit");
-        assert_eq!(hit.code, CheatCode::EvalShortCircuit);
+        assert_eq!(hit.kind, SourceCheatKind::EvalShortCircuit);
     }
 
     #[test]
@@ -74,7 +72,7 @@ mod tests {
             "def train(m, ctx):\n    return {}\n",
         )
         .expect("hit");
-        assert_eq!(hit.code, CheatCode::MissingTelemetryHooks);
+        assert_eq!(hit.kind, SourceCheatKind::MissingTelemetryHooks);
     }
 
     #[test]

crates/prism-challenge/src/lib.rs

@@ -16,10 +16,13 @@ mod api;
 mod leaf_emit;
 pub mod orchestrator;
 mod score;
-mod submit;
 
 pub use api::{record_epoch, submission_router, AppState};
-pub use leaf_emit::{emit_signed_leaf_set, public_key_from_secret, verify_leaf_sig, LeafEmitError};
+pub use challenge_common::{
+    public_key_from_secret, submit_signed_leaf_set, verify_leaf_sig, GatewayClient,
+    GatewayClientConfig, LeafEmitError, SubmitError, SubmitOutcome,
+};
+pub use leaf_emit::emit_signed_leaf_set;
 pub use orchestrator::{Orchestrator, OrchestratorConfig};
 pub use prism_challenge_task::{
     CHALLENGE_ID, CHALLENGE_ID_BYTES, SCORE_MAX, SCORING_VERSION, TASK_ID_DOMAIN,
@@ -36,9 +39,6 @@ pub use prism_store::{
     StoreError, SubmissionState,
 };
 pub use score::{combine_final, FinalOutcome};
-pub use submit::{
-    submit_signed_leaf_set, GatewayClient, GatewayClientConfig, SubmitError, SubmitOutcome,
-};
 
 pub use bundle::{LeafV1, NoScoreReasonCode, ScoreOrAbsence};
 pub use crypto::KEY_LEN;

crates/prism-challenge/src/orchestrator.rs

@@ -22,7 +22,7 @@ use chain::ChainClient;
 use challenge_agentic::{
     copy_gate, static_source_cheat, AgenticBackend, AgenticVerdict, VerdictKind,
 };
-use challenge_common::{expected_set_at_chain, PinnedBlockHash};
+use challenge_common::{expected_set_at_chain, GatewayClient, PinnedBlockHash};
 use crypto::KEY_LEN;
 use prism_emit::EpochEmitter;
 use prism_lium::{EvalJobBackend, InstanceSpec};
@@ -35,7 +35,6 @@ use tracing::{info, warn};
 
 use crate::agentic::{build_review_request, corpus_from_rows, gate_corpus_from_rows, same_miner};
 use crate::score::{combine_final, FinalOutcome};
-use crate::submit::GatewayClient;
 use prism_store::{FinalScore, PrismStore, Stage, StageEvent, StatePatch, SubmissionState};
 
 /// Worker + emitter settings.
@@ -115,7 +114,7 @@ impl<C: ChainClient + Send> Orchestrator<C> {
         chain: Arc<C>,
         sk: [u8; KEY_LEN],
     ) -> Self {
-        let emitter = EpochEmitter::new(Arc::clone(&store), sk, cfg.netuid, gateway.common());
+        let emitter = EpochEmitter::new(Arc::clone(&store), sk, cfg.netuid, gateway.clone());
         Self {
             cfg,
             store,
@@ -523,7 +522,7 @@ impl<C: ChainClient + Send> Orchestrator<C> {
         };
         warn!(
             submission_id = %row.id,
-            code = ?hit.code,
+            kind = ?hit.kind,
             rationale = %hit.rationale,
             "static source cheat rejected (pod skipped)"
         );
@@ -532,7 +531,7 @@ impl<C: ChainClient + Send> Orchestrator<C> {
             None,
             Some(serde_json::json!({
                 "gate": "static_source",
-                "cheat_code": format!("{:?}", hit.code),
+                "cheat_kind": format!("{:?}", hit.kind),
                 "rationale": hit.rationale,
             })),
             hit.rationale.clone(),

crates/prism-challenge/src/submit.rs

@@ -138,7 +138,8 @@ fn mk_orchestrator(
     let gateway = Arc::new(
         GatewayClient::new(GatewayClientConfig {
             base_url: "dry-run".into(),
-            max_retries: 0,
+            max_attempts: 1,
+            backoff: std::time::Duration::from_millis(1),
         })
         .unwrap(),
     );

crates/prism-challenge/tests/arch_competition.rs

@@ -83,7 +83,8 @@ async fn baseline_arch_train_copy_scores_zero() {
     let gateway = Arc::new(
         GatewayClient::new(GatewayClientConfig {
             base_url: "dry-run".into(),
-            max_retries: 0,
+            max_attempts: 1,
+            backoff: std::time::Duration::from_millis(1),
         })
         .unwrap(),
     );

crates/prism-challenge/tests/cheat_arch_copy.rs

@@ -82,7 +82,8 @@ async fn hardcoded_metrics_json_scores_zero() {
     let gateway = Arc::new(
         GatewayClient::new(GatewayClientConfig {
             base_url: "dry-run".into(),
-            max_retries: 0,
+            max_attempts: 1,
+            backoff: std::time::Duration::from_millis(1),
         })
         .unwrap(),
     );