pass the parser around

Author: albertobruin

cmd/lint.go

@@ -2,6 +2,7 @@ package cmd
 
 import (
 	"fmt"
+	"github.com/bruin-data/bruin/pkg/sqlparser"
 	"io"
 	"os"
 	path2 "path"
@@ -108,7 +109,12 @@ func Lint(isDebug *bool) *cli.Command {
 
 			logger.Debugf("built the connection manager instance")
 
-			rules, err := lint.GetRules(fs, &git.RepoFinder{}, c.Bool("exclude-warnings"))
+			parser, err := sqlparser.NewSQLParser()
+			if err != nil {
+				printError(err, c.String("output"), "Could not initialize sql parser")
+			}
+
+			rules, err := lint.GetRules(fs, &git.RepoFinder{}, c.Bool("exclude-warnings"), parser)
 			if err != nil {
 				printError(err, c.String("output"), "An error occurred while building the validation rules")
 

cmd/run.go

@@ -3,6 +3,7 @@ package cmd
 import (
 	"context"
 	"fmt"
+	"github.com/bruin-data/bruin/pkg/sqlparser"
 	"io"
 	"log"
 	"os"
@@ -267,7 +268,12 @@ func Run(isDebug *bool) *cli.Command {
 				infoPrinter.Printf("Running only the asset '%s'\n", task.Name)
 			}
 
-			rules, err := lint.GetRules(fs, &git.RepoFinder{}, true)
+			parser, err := sqlparser.NewSQLParser()
+			if err != nil {
+				printError(err, c.String("output"), "Could not initialize sql parser")
+			}
+
+			rules, err := lint.GetRules(fs, &git.RepoFinder{}, true, parser)
 			if err != nil {
 				errorPrinter.Printf("An error occurred while linting the pipelines: %v\n", err)
 				return cli.Exit("", 1)

go.mod

@@ -8,7 +8,6 @@ require (
 	cloud.google.com/go/bigquery v1.60.0
 	github.com/DATA-DOG/go-sqlmock v1.5.0
 	github.com/alecthomas/chroma/v2 v2.13.0
-	github.com/cenkalti/backoff v2.2.1+incompatible
 	github.com/charmbracelet/bubbletea v1.1.2
 	github.com/databricks/databricks-sql-go v1.6.0
 	github.com/denisbrodbeck/machineid v1.0.1

go.sum

@@ -109,8 +109,6 @@ github.com/bahlo/generic-list-go v0.2.0/go.mod h1:2KvAjgMlE5NNynlg/5iLrrCCZ2+5xW
 github.com/buger/jsonparser v1.1.1 h1:2PnMjfWD7wBILjqQbt530v576A/cAbQvEW9gGIpYMUs=
 github.com/buger/jsonparser v1.1.1/go.mod h1:6RYKKt7H4d4+iWqouImQ9R2FZql3VbhNgx27UK13J/0=
 github.com/cactus/go-statsd-client/statsd v0.0.0-20200423205355-cb0885a1018c/go.mod h1:l/bIBLeOl9eX+wxJAzxS4TveKRtAqlyDpHjhkfO0MEI=
-github.com/cenkalti/backoff v2.2.1+incompatible h1:tNowT99t7UNflLxfYYSlKYsBpXdEet03Pg2g16Swow4=
-github.com/cenkalti/backoff v2.2.1+incompatible/go.mod h1:90ReRw6GdpyfrHakVjL/QHaoyV4aDUVVkXQJJJ3NXXM=
 github.com/census-instrumentation/opencensus-proto v0.2.1/go.mod h1:f6KPmirojxKA12rnyqOA5BBL4O983OfeGPqjHWSTneU=
 github.com/charmbracelet/bubbletea v1.1.2 h1:naQXF2laRxyLyil/i7fxdpiz1/k06IKquhm4vBfHsIc=
 github.com/charmbracelet/bubbletea v1.1.2/go.mod h1:9HIU/hBV24qKjlehyj8z1r/tR9TYTQEag+cWZnuXo8E=

pkg/lint/list.go

@@ -6,8 +6,6 @@ import (
 	"github.com/bruin-data/bruin/pkg/git"
 	"github.com/bruin-data/bruin/pkg/glossary"
 	"github.com/bruin-data/bruin/pkg/jinja"
-	"github.com/bruin-data/bruin/pkg/sqlparser"
-	"github.com/pkg/errors"
 	"github.com/samber/lo"
 	"github.com/spf13/afero"
 )
@@ -16,19 +14,14 @@ type repoFinder interface {
 	Repo(path string) (*git.Repo, error)
 }
 
-func GetRules(fs afero.Fs, finder repoFinder, excludeWarnings bool) ([]Rule, error) {
+func GetRules(fs afero.Fs, finder repoFinder, excludeWarnings bool, parser sqlParser) ([]Rule, error) {
 	gr := GlossaryChecker{
 		gr: &glossary.GlossaryReader{
 			RepoFinder: finder,
 			FileNames:  []string{"glossary.yml", "glossary.yaml"},
 		},
 	}
 
-	parser, err := sqlparser.NewSQLParser()
-	if err != nil {
-		return make([]Rule, 0), errors.Wrap(err, "failed to instantiate sql parser")
-	}
-
 	rules := []Rule{
 		&SimpleRule{
 			Identifier:       "task-name-valid",