Skip to content

Commit 3eae30e

Browse files
authored
VAPI-2528 Fix Start Stream BXML Bug (#265)
1 parent 18e68d2 commit 3eae30e

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

bandwidth/models/bxml/verbs/start_stream.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@
1414
class StartStream(NestableVerb):
1515

1616
def __init__(
17-
self, destination: str, destination_username: str,
18-
destination_password: str, stream_params: List[StreamParam] = [],
17+
self, destination: str, destination_username: str=None,
18+
destination_password: str=None, stream_params: List[StreamParam] = [],
1919
name: str=None, mode: str=None, tracks: str=None,
2020
stream_event_url: str=None,
2121
stream_event_method: str=None,
@@ -59,8 +59,8 @@ def __init__(
5959
def _attributes(self):
6060
return {
6161
"destination": self.destination,
62-
"destination_username": self.destination_username,
63-
"destination_password": self.destination_password,
62+
"destinationUsername": self.destination_username,
63+
"destinationPassword": self.destination_password,
6464
"name": self.name,
6565
"mode": self.mode,
6666
"tracks": self.tracks,

test/unit/models/bxml/test_start_stream.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,10 @@ def test_instance(self):
4343
assert isinstance(self.start_stream, Verb)
4444

4545
def test_to_bxml(self):
46-
expected = '<StartStream destination="testurl.com" destination_username="dest_user" destination_password="dest_pass" name="stream1" mode="bidirectional" tracks="inbound" streamEventUrl="eventurl.com" streamEventMethod="POST" username="user" password="pass"><StreamParam name="name1" value="value1" /></StartStream>'
46+
expected = '<StartStream destination="testurl.com" destinationUsername="dest_user" destinationPassword="dest_pass" name="stream1" mode="bidirectional" tracks="inbound" streamEventUrl="eventurl.com" streamEventMethod="POST" username="user" password="pass"><StreamParam name="name1" value="value1" /></StartStream>'
4747
assert expected == self.start_stream.to_bxml()
4848

4949
def test_add_verb(self):
50-
expected = '<StartStream destination="testurl.com" destination_username="dest_user" destination_password="dest_pass" name="stream1" mode="bidirectional" tracks="inbound" streamEventUrl="eventurl.com" streamEventMethod="POST" username="user" password="pass"><StreamParam name="name1" value="value1" /><StreamParam name="name2" value="value2" /></StartStream>'
50+
expected = '<StartStream destination="testurl.com" destinationUsername="dest_user" destinationPassword="dest_pass" name="stream1" mode="bidirectional" tracks="inbound" streamEventUrl="eventurl.com" streamEventMethod="POST" username="user" password="pass"><StreamParam name="name1" value="value1" /><StreamParam name="name2" value="value2" /></StartStream>'
5151
self.start_stream.add_verb(self.stream_param2)
5252
assert expected == self.start_stream.to_bxml()

0 commit comments

Comments
 (0)